Fixed
Status Update
No update yet.
Comments
ra...@google.com
since these are in public API (:/) we need to do this in 1.2
st...@baramundi.de
since it is already marked as deprecated, we can probably do it by now.
ra...@google.com
Opening diff shortly
ra...@google.com
ra...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c0b51deb20e4775627bb2a379625d14a65779a39
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Sep 18 22:21:02 2018
Fixes the 100 Jobs scheduler limit problem.
* `WorkerWrapper` now correctly cancels `Worker`s in other schedulers
after the `WorkSpec` reaches a terminal state.
Test: Added a new integration test.
Change-Id: I2ad63cd77407bded7c720fc1015182820d63a36d
Fixes:
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/TestWorker.java
M work/integration-tests/testapp/src/main/res/layout/activity_main.xml
M work/integration-tests/testapp/src/main/res/values/strings.xml
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
https://android-review.googlesource.com/760298
https://goto.google.com/android-sha1/c0b51deb20e4775627bb2a379625d14a65779a39
Branch: androidx-master-dev
commit c0b51deb20e4775627bb2a379625d14a65779a39
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Sep 18 22:21:02 2018
Fixes the 100 Jobs scheduler limit problem.
* `WorkerWrapper` now correctly cancels `Worker`s in other schedulers
after the `WorkSpec` reaches a terminal state.
Test: Added a new integration test.
Change-Id: I2ad63cd77407bded7c720fc1015182820d63a36d
Fixes:
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/TestWorker.java
M work/integration-tests/testapp/src/main/res/layout/activity_main.xml
M work/integration-tests/testapp/src/main/res/values/strings.xml
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
st...@baramundi.de
Sorry for the delayed reply. The tests you suggested did show a problem on version alpha08 (Sometimes the jobs wasn't removed fast enouth after finishing).
But as you already provided the fix, this shouldn't be something new to you.
I attached the log files just for completeness...
I can no longer reproduce the issue on alpha09 on my devices. Thank you for your swift fix and release.
But as you already provided the fix, this shouldn't be something new to you.
I attached the log files just for completeness...
I can no longer reproduce the issue on alpha09 on my devices. Thank you for your swift fix and release.
ra...@google.com
Thanks for the confirmation.
Description
Version used: 1.0.0-alpha08
Devices/Android versions reproduced on: Moto G5s Plus, Android 7.1.1 / Huawai P20 lite, Android 8.0.0
We can reproduce a crash of the workmanager on some devices.
In our code we enqueue a UniqueWork with ExistingWorkPolicy.REPLACE, as soon as it finishes with State.SUCEEDED we enqueue it again. There is always only one job at the time.
After about 100 jobs the workmanager crashes with: java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs.
It looks like the workmanager does not prune the finished jobs fast enough, and they count as 'sheduled' job, even if they are finished?
The crash is reproducible on the Moto G5s Plus and Huawai P20 lite. But it behaves very inconsistent, sometimes it occurs on the first run, sometimes only after a few restarts of the app. But we cannot reproduce it on the Pixel 2 XL or the emulator.
Calling pruneWork() before enqueue() doesn't fix the problem.
Reducing the result lifetime by calling keepResultsForAtLeast(..) doesn't work as well.
We provided a sample app which triggers the issue.