Kotlin Plugin causing deprecation warning [116198439]

Fixed

Bug

[AOSP] win10

Status Update

No update yet.

Description

sm...@google.com

created issue #1

Sep 20, 2018 01:30PM

All projects applying 'kotlin-android' with the current AGP are generating the following warning:

WARNING: API 'variant.getJavaCompile()' is obsolete and has been replaced with 'variant.getJavaCompileProvider()'.
It will be removed at the end of 2019.
For more information, see

https://d.android.com/r/tools/task-configuration-avoidance
Affected Modules: app

This seems to be due to a call in AndroidGradleWrapper.kt line 32 (from the Kotlin plugin)

Comments

sm...@google.com <sm...@google.com> #2Sep 20, 2018 01:35PM

Reassigned to xa...@google.com.

Hi Josh, friendly ping for an update on progress

xa...@google.com <xa...@google.com> #3Sep 20, 2018 03:54PM

Reassigned to ga...@google.com.

i think the TL;DR is that this is stuck behind investigating the current lab outages, which are more urgent.

pending CL is https://android-review.googlesource.com/c/platform/system/core/+/1250677.

ga...@google.com <ga...@google.com> #4Sep 20, 2018 03:56PM

Have you consider snappy or zstd? From my experience snappy compresses at around 200~300MB/s with reasonable compression rate ~30%.

hu...@google.com <hu...@google.com> #5Sep 21, 2018 12:40AM

For brotli, try quality level 1, this can give around 150-200MB/s with a much better compression ration than snappy of over 60%. Brotli quality 0 is even faster for still over 50% compression.

ga...@google.com <ga...@google.com> #6Sep 21, 2018 01:08PM

Hmm, gerrit-watcher didn't post the CLs on this bug, so I guess I'll do so manually:

https://android.googlesource.com/platform/system/core/+/939fc19aee7f6a19ce0f4fa91557bbbe9cd974f5 added brotli support (with quality level 1)

https://android.googlesource.com/platform/system/core/+/ec44d35fde60d20d9ab1c6fb9ac7ee844335f1eb added LZ4

Throughput numbers from a device:

           none    brotli    lz4
USB 3.0     120       110    190
USB 2.0      38        75     63

I'm seeing identical throughput with brotli quality 0 and 1 (110MB/s end to end), although there's some giant low hanging fruit to compress multiple files at once.

zstd isn't in the tree yet (I started the ball rolling on that, but no idea when it'll end up getting merged), but I'll take a look at it eventually, probably when I get around to implementing compression for generic streams in adb (b/153901735).

This is probably good enough to call this fixed for now.

xa...@google.com <xa...@google.com> #7Sep 21, 2018 04:16PM

This is not really fixing what we need though. We need the Kotlin plugin to also stop force-creating these tasks. All this does is remove the warning.

ga...@google.com <ga...@google.com> #8Sep 21, 2018 06:21PM

Marked as fixed.

I am working on a more elaborate fix, that should avoid these integration issues. Let's keep this bug focused on removing the warning, and lazy tasks will be tackled separately.

xa...@google.com <xa...@google.com> #9Sep 21, 2018 06:23PM

Let's make sure we have a bug to track this.

lb...@gmail.com <lb...@gmail.com> #10Sep 21, 2018 06:47PM

@8 I prefer not to add this workaround that will probably be forgotten later when it's actually fixed.

xa...@google.com <xa...@google.com> #11Sep 21, 2018 07:06PM

The proper fix is actually quite complex and this temporary workaround will have to be removed to do the proper fix so I'm not worried about that.

lb...@gmail.com <lb...@gmail.com> #12Sep 21, 2018 07:24PM

@11 I don't think that when Google fix the issue, they will also add an automatic/manual removal of the workaround.
It's better that the IDE will have a workaround built in, and a fix later, than having it in each project, that will require us all to remember to remove it somewhere in the future.

xa...@google.com <xa...@google.com> #13Sep 21, 2018 07:28PM

There is no fix in the Android Gradle Plugin. The API is deprecated on purpose. The workaround is in the Kotlin plugin and the final fix will also be in the Kotlin plugin.

lb...@gmail.com <lb...@gmail.com> #14Sep 21, 2018 07:31PM

@13 In any case, the current situation is that Google published a version of the IDE that creates a warning even on completely new projects.

xa...@google.com <xa...@google.com> #15Sep 21, 2018 08:43PM

Yes this is the case.

xa...@google.com <xa...@google.com> #16Sep 21, 2018 08:45PM

BTW we're well aware of what the current situation is. It's also a canary build so it's not a huge deal.
Doing this change early allows us to see who uses that deprecated API. We pushed a fix to the Kotlin plugin. By the time 3.3 is stable there should be a Kotlin version out there that does not access the API.

lb...@gmail.com <lb...@gmail.com> #17Sep 22, 2018 08:21AM

@16 Will there be a newer canary with this fix?

xa...@google.com <xa...@google.com> #18Sep 22, 2018 05:43PM

As soon as the Kotlin plugin with the fix is released, Studio will be updated to use this by default. I think we generally track new Kotlin version very closely.

lb...@gmail.com <lb...@gmail.com> #19Sep 23, 2018 01:52PM

@18 I can't find the workaround anymore. Can you please write it again?