Fixed
Status Update
Comments
il...@google.com <il...@google.com>
yb...@google.com <yb...@google.com> #2
override we can fix but @Generated seems hard as we need to know whether the app has Generated in its classpath and we don't know that information in the gradle plugin :/.
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 8c03f8ea9c3f53303e75e430a75f248050f65f8c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Dec 03 14:12:31 2018
Add @Override to getArguments() and getActionId() methods generated
by the Safe Args plugin.
Bug: 117145301
Test: ./gradlew navigation:navigation-safe-args-generator:test
Change-Id: I973e5f567432601e2ddd616ce89f3b23a831fd88
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/LoginDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/LoginFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/MainFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Finish.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/SanitizedMainFragmentDirections.java
https://android-review.googlesource.com/839772
https://goto.google.com/android-sha1/8c03f8ea9c3f53303e75e430a75f248050f65f8c
Branch: androidx-master-dev
commit 8c03f8ea9c3f53303e75e430a75f248050f65f8c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Dec 03 14:12:31 2018
Add @Override to getArguments() and getActionId() methods generated
by the Safe Args plugin.
Bug: 117145301
Test: ./gradlew navigation:navigation-safe-args-generator:test
Change-Id: I973e5f567432601e2ddd616ce89f3b23a831fd88
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/LoginDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/LoginFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/MainFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Finish.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/SanitizedMainFragmentDirections.java
il...@google.com <il...@google.com> #4
We now add the @Override annotation where appropriate and this will be available in Navigation 1.0.0-alpha08. As per #2, @Generated was not added. Please let us know if you see any other Lint warnings, etc. from Safe Args generated code.
Description
Version used: 1.0.0-alpha06
Devices/Android versions reproduced on: -
As the title says the generated *Directions classes are missing the @Generated() annotation and both the getArguments() and getActionId() implementations are missing the @Override annotation.