IssueTracker

Can you tell us which devices are exhibiting this problem?

They're the following, sorted by percentage of occurrences:

P8 Lite
P8
Honor 5X
Honor 7
Y6II
honor 6C
X2
Mate S
Mate 7
GX8

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6206758647365632/#/cherrypickHistory/all)
  Created: 2019-07-26 23:31:17.300138+00:00
  Changes: aosp/1092375
 

This also seems to happen in SystemJobService.onStartJob. Should I create a new bug?

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object android.util.ArrayMap.get(java.lang.Object)' on a null object reference
       at android.os.BaseBundle.getString + 928(BaseBundle.java:928)
       at androidx.work.impl.background.systemjob.SystemJobService.onStartJob + 104(SystemJobService.java:104)
       at android.app.job.JobService$JobHandler.handleMessage + 126(JobService.java:126)
       at android.os.Handler.dispatchMessage + 102(Handler.java:102)
       at android.os.Looper.loop + 150(Looper.java:150)
       at android.app.ActivityThread.main + 5621(ActivityThread.java:5621)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run + 794(ZygoteInit.java:794)
       at com.android.internal.os.ZygoteInit.main + 684(ZygoteInit.java:684)

Yes, please do. I can take a look.

It's here now: https://issuetracker.google.com/issues/138441699

Thank you for fixing this so quickly.

Thanks for the sample app. I haven't gotten to the bottom of the issue yet but I wanted to give you an update and it does seem indeed that Room is taking a very long time to parse and understand your queries via the ANTLR generated parser that Room uses. I'm not sure what is so special about your queries that is causing this, but I'll comment back with an update once I find out. Sadly for now I don't have a recommendation on a workaround.

Alright, I've drill down the problem to being the various "OR <col_name> LIKE '%' : text '%'" in your queries. Specifically they cause the SQLiteParser in Room to go down a path with poor performance as described in https://github.com/antlr/antlr4/issues/1398. A fix for this involves updating Room's ANTRL runtime library and generated parser code with the latest version. This update will likely be available in Room 2.1.0-alpha02.

Thanks for the update. Is 2.1.0-alpha02 around the corner?

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8e46b9ca1f55b040a18dd86833880b5106d103b2
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Wed Oct 10 19:17:50 2018

    Update Room's ANTLR Parser to 4.7.1
   
    Updating to the latest ANTLR version fixes the performance issue
    described in https://github.com/antlr/antlr4/issues/1398 which affects
    Room's SQL Parser since it contains left-recursive rules. Specifically
    SQLite.g4 has multiple recursions to describe an expression as defined
    in https://www.sqlite.org/lang_expr.html, meaning if a user has certain
    queries that causes the parser to use the adaptivePredict algorithm
    then the build time increases significantly due to Room's query
    parsing.
   
    Also bumped Room's version to 2.1.0-alpha02
   
    Bug: 117401230
    Test: ./gradlew room:integration-tests:testapp:cC
    Change-Id: I4d0799a11ccee816ab209cbf74e7dcf2b2ce1a18

M       buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M       buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M       room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/UserDao.java

https://android-review.googlesource.com/786077
https://goto.google.com/android-sha1/8e46b9ca1f55b040a18dd86833880b5106d103b2

No concrete date on 2.1.0-alpha02, I want to get a few more bugs in before making the next alpha release. So maybe by the end of the month.

Thanks.

On Tue, Oct 16, 2018, 4:52 AM <buganizer-system@google.com> wrote:

--

- Ankit