Room compiler takes 15 mins to do code generation [117401230]

Fixed

Bug

Status Update

No update yet.

Description

an...@gmail.com

created issue #1

Oct 8, 2018 04:10PM

Component used: android.arch.persistence.room:compiler
Version used: 1.1.1
Devices/Android versions reproduced on: Latest android emulator on Mac OS running Oreo image, Lenovo K6 Power
Also tried with Android studio 3.2 stable and Android 3.3 Preview version as well.

Building my project takes 15 min. If I comment out below line

annotationProcessor "android.arch.persistence.room:compiler:$ROOM_VERSION"

from my app's build.gradle, it takes only a minute to build the project. It's not a very big project (entity count wise) and I did not try reproducing the issue in a sample project. However, I can reproduce the

issue 100

% of the time with my project.

I have tried:

1. Cleaning. Rebuilding...
2. Invalidate caches/Restart.
3. Even tried migration to using all the androidx artifacts.

It seems like a bug in Room's annotationProcessor but I don't have a sample project to share.

Comments

yb...@google.com <yb...@google.com> #2Oct 8, 2018 04:44PM

Reassigned to da...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 1b9ae441be4de3443b138e789c85722bba29c356
Author: Clara F <clarafok@google.com>
Date: Mon Mar 14 15:26:56 2022

[GH] Add room-paging-guava module to Room

Create module for integrating Guava into Room Paging

Test: n/a
Bug: 203666906

This is an imported pull request from

https://github.com/androidx/androidx/pull/337.

Resolves #337

Relnote: "Added a new artifact, room-paging-guava, for ListenableFuturePagingSource in
room-paging."

Github-Pr-Head-Sha: f62df108d6d5dd765c43b1e75472ddd0a097f9de
GitOrigin-RevId: 8c86aaa8e3a856614cbdccabe07c0d658efb0407
Change-Id: Ie14a1beef5d3b7ba07f3acc3fdd1f7bfc6fd1b9e

A room/room-paging-guava/src/androidTest/AndroidManifest.xml
A room/room-paging-guava/api/public_plus_experimental_current.txt
M settings.gradle
M docs-tip-of-tree/build.gradle
A room/room-paging-guava/api/restricted_current.txt
A room/room-paging-guava/api/res-current.txt
A room/room-paging-guava/src/main/AndroidManifest.xml
A room/room-paging-guava/api/current.txt
A room/room-paging-guava/build.gradle

https://android-review.googlesource.com/2025245

an...@gmail.com <an...@gmail.com> #3Oct 8, 2018 04:59PM

Project: platform/frameworks/support
Branch: androidx-main

commit eb60980fbbeb3a9d824e721969a54db902c44857
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:08:03 2022

[GH] Add room-paging-rxjava3 module to Room

Test: n/a
Bug: 203666906
Relnote: Integrating rxjava3 support in Room Paging

This is an imported pull request from

https://github.com/androidx/androidx/pull/339.

Resolves #339
Github-Pr-Head-Sha: 274be4dcfc6f40861b476638c9671503e28129d4
GitOrigin-RevId: f081e641921b7dd64f1bba5800b4395074f902e1

Change-Id: I00d8884025aa4263a96dc509ccb8e303b53beeb8

M settings.gradle
A room/room-paging-rxjava3/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava3/api/restricted_current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava3/api/current.txt
A room/room-paging-rxjava3/build.gradle
A room/room-paging-rxjava3/src/main/AndroidManifest.xml
A room/room-paging-rxjava3/api/public_plus_experimental_current.txt
A room/room-paging-rxjava3/api/res-current.txt

https://android-review.googlesource.com/2027363

an...@gmail.com <an...@gmail.com> #4Oct 9, 2018 08:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 41a1d4f8677c57db934d37bb0cd8db9d3f3aae6c
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:10:36 2022

[GH] Add room-paging-rxjava2 module to Room

Test: n/a
Bug: 203666906
Relnote: "Added new artifact room-paging-rxjava2 for rxjava2 support in Room Paging"

This is an imported pull request from

https://github.com/androidx/androidx/pull/338.

Resolves #338
Github-Pr-Head-Sha: f8c5c6f04217e43bbc4a78b9715deb920b830fa3
GitOrigin-RevId: 1dbf1e202286c42fc34c89a808d8c421fa1303af

Change-Id: I88f076392f1917c2fec52d3bd58d91e73b12a53b

A room/room-paging-rxjava2/api/current.txt
A room/room-paging-rxjava2/api/restricted_current.txt
M settings.gradle
A room/room-paging-rxjava2/api/res-current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava2/src/main/AndroidManifest.xml
A room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava2/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2027364

room-compiler-performance-issue.zip

6.7 MB

Download

an...@gmail.com <an...@gmail.com> #5Oct 10, 2018 05:16AM

Project: platform/frameworks/support
Branch: androidx-main

commit 2f45502b3d448965f0e52067e8b39108708d1faf
Author: clarafok <clarafok@google.com>
Date: Mon Apr 11 15:50:07 2022

Implement LimitOffsetListenableFuturePagingSource

An abstract implementation of ListenableFuturePagingSource to be
implemented by Room. Supports Guava operations through ListenableFuture.

Test: ./gradlew room:room-paging-guava:cC
Bug: 203666906

Change-Id: I3ec746a072d28e856018d03aeb08931a8d42fa93

A room/room-paging-guava/src/main/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
A room/room-paging-guava/src/androidTest/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSourceTest.kt
M room/room-paging/build.gradle
M room/room-paging-guava/build.gradle
M room/room-paging/src/main/kotlin/androidx/room/paging/util/RoomPagingUtil.kt

https://android-review.googlesource.com/2037356

an...@gmail.com <an...@gmail.com> #6Oct 10, 2018 11:39AM

Project: platform/frameworks/support
Branch: androidx-main

commit 76e8c1ef8e3f90ecb1376ec0d0dc418990b7e515
Author: Clara Fok <clarafok@google.com>
Date: Thu Apr 28 17:05:24 2022

Hook up room-paging-guava to room-compiler

Test: ./gradlew :room:room-compiler:test
Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: Iaa2e7b542b4398f2e364c0b68896c046589e9a09

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/ListenableFuturePagingSourceQueryResultBinderProvider.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/integration-tests/kotlintestapp/build.gradle
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/MultiTypedPagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-paging-guava/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/ItemStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetListenableFuturePagingSource.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/PagingSourceQueryResultBinderProvider.kt
M testutils/testutils-common/src/main/java/androidx/testutils/FilteringExecutor.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/room-compiler/src/test/data/common/input/ListenableFuturePagingSource.java

https://android-review.googlesource.com/2067883

an...@gmail.com <an...@gmail.com> #7Oct 10, 2018 11:57AM

Project: platform/frameworks/support
Branch: androidx-main

commit a5a856d88a480cbb1d4364f6b3d64ff450411cfd
Author: clarafok <clarafok@google.com>
Date: Wed May 11 13:52:19 2022

Implement room-paging-rxjava3 LimitOffsetRxPagingSource

Test: ./gradlew room:room-paging-rxjava3:cC
Bug: 203666906
Change-Id: I0127af74e4ec38c0570f56a5783ec2157f9bb9fc

A room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
A room/room-paging-rxjava3/src/androidTest/kotlin/androidx/room/paging/rxjava3/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava3/build.gradle

https://android-review.googlesource.com/2094107

da...@google.com <da...@google.com> #8Oct 10, 2018 11:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit c7b01e966accae484bb1dd081e3fa5f3f38047fc
Author: clarafok <clarafok@google.com>
Date: Thu May 12 15:28:45 2022

Hook up rxjava3 LimitOffsetRxPagingSource to room-compiler

Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: I57099d83a8c845263c5031990de3124971ac2363

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
A room/room-compiler/src/test/data/common/input/Rx3PagingSource.java
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx3PagingSource.java
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava3PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt

https://android-review.googlesource.com/2097220

da...@google.com <da...@google.com> #9Oct 11, 2018 03:22AM

Project: platform/frameworks/support
Branch: androidx-main

commit c4782c289e754747e1a98a28e2700836d78d7578
Author: clarafok <clarafok@google.com>
Date: Fri May 13 14:12:02 2022

Implement rxjava2 LimitOffsetRxPagingSource

Test: ./gradlew room:room-paging-rxjava2:cC
Bug: 203666906
Change-Id: Iefd883d45b18b032bb3a29d51209fc7de169c1aa

A room/room-paging-rxjava2/src/androidTest/kotlin/androidx/room/paging/rxjava2/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt

https://android-review.googlesource.com/2098470

an...@gmail.com <an...@gmail.com> #10Oct 11, 2018 02:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit d1ba57918465b84aa9564074df68d3136a4f8fcd
Author: clarafok <clarafok@google.com>
Date: Fri May 13 16:09:09 2022

Hook up room-paging-rxjava2 to room-compiler

Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Fixes: 203666906
Change-Id: Ic8f07f14491ece38b1296ca71c761511218a65a9

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/test/data/common/input/Rx2PagingSource.java
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava2PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx2PagingSource.java
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt

https://android-review.googlesource.com/2098475

ap...@google.com <ap...@google.com> #11Oct 11, 2018 09:57PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8e46b9ca1f55b040a18dd86833880b5106d103b2
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Oct 10 19:17:50 2018

Update Room's ANTLR Parser to 4.7.1

Updating to the latest ANTLR version fixes the performance issue
described in

https://github.com/antlr/antlr4/issues/1398 which affects
Room's SQL Parser since it contains left-recursive rules. Specifically
SQLite.g4 has multiple recursions to describe an expression as defined
in

https://www.sqlite.org/lang_expr.html, meaning if a user has certain
queries that causes the parser to use the adaptivePredict algorithm
then the build time increases significantly due to Room's query
parsing.

Also bumped Room's version to 2.1.0-alpha02

Bug: 117401230
Test: ./gradlew room:integration-tests:testapp:cC
Change-Id: I4d0799a11ccee816ab209cbf74e7dcf2b2ce1a18

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/UserDao.java

https://android-review.googlesource.com/786077

https://goto.google.com/android-sha1/8e46b9ca1f55b040a18dd86833880b5106d103b2

da...@google.com <da...@google.com> #12Oct 15, 2018 11:22PM

Marked as fixed.

No concrete date on 2.1.0-alpha02, I want to get a few more bugs in before making the next alpha release. So maybe by the end of the month.

an...@gmail.com <an...@gmail.com> #13Oct 16, 2018 08:22PM

Thanks.

On Tue, Oct 16, 2018, 4:52 AM <buganizer-system@google.com> wrote:

- Show quoted text -

--

- Ankit