Illegal start of expression for Transaction without argument [117527454]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Oct 10, 2018 06:43AM

Component used: androidx.room:room-runtime, androidx.room:room-compiler
Version used: 2.0.0
Devices/Android versions reproduced on: N / A

@Dao
interface Foo {
@Query("SELECT * FROM bar")
fun getAll(): List<Bar>

@Transaction
fun getTransactionAll(): List<Bar> {
return getAll()
}
}

It generates

Foo.DefaultImpls.getTransactionAll(this, )

which cause the error (illegal start of expression) because of the extra comma.

Comments

yb...@google.com <yb...@google.com> Oct 10, 2018 03:55PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #2Oct 24, 2018 04:10PM

Thanks for reporting this - Looks like Room is trying to give you a warning, possibly POJO & query result column mismatch, but it fails format the message. I guess safeFormat() is not very safe after all. >.>
Could you please provide your full method signature for the failing query method case? If the return type is a data class it would be nice if you could also provide it.

da...@google.com <da...@google.com> #3Oct 24, 2018 04:12PM

Marked as fixed.

What is the alarm sounds that every seems to know about but me it's like I'm being tracked everywhere I go

ta...@gmail.com <ta...@gmail.com> #4Nov 13, 2018 12:00AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c08fa5ad19b227e73cfcf9fd8e0994ec32273bce
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Nov 14 13:38:50 2018

Make RLog's safeFormat() truly safe by catching all exceptions.

Bug: 119520136
Test: RLogTest
Change-Id: I81c8a4ed9e03b64d6762a9976d2dfcd12ea8327b

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
A room/compiler/src/test/kotlin/androidx/room/log/RLogTest.kt

https://android-review.googlesource.com/826949

https://goto.google.com/android-sha1/c08fa5ad19b227e73cfcf9fd8e0994ec32273bce

[Deleted User] <[Deleted User]> #5Jan 2, 2019 01:55AM

A fix for this will be available in Room 2.1.0-alpha03

[Deleted User] <[Deleted User]> #6Jan 2, 2019 02:10AM

Great news -- thank you for fast turnaround!

Issue 117527454