Illegal start of expression for Transaction without argument [117527454]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Oct 10, 2018 06:43AM

Component used: androidx.room:room-runtime, androidx.room:room-compiler
Version used: 2.0.0
Devices/Android versions reproduced on: N / A

@Dao
interface Foo {
@Query("SELECT * FROM bar")
fun getAll(): List<Bar>

@Transaction
fun getTransactionAll(): List<Bar> {
return getAll()
}
}

It generates

Foo.DefaultImpls.getTransactionAll(this, )

which cause the error (illegal start of expression) because of the extra comma.

Comments

yb...@google.com <yb...@google.com> Oct 10, 2018 03:55PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #2Oct 24, 2018 04:10PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3eb053061ebd600de2ce0d13994c7f227711b21e
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue May 28 09:54:27 2024

Fix find database impl reflection when class has no package.

Handle the Android only (not reproducible in JVM) case when a class has no package and the getPackage() call on the Class returns null.

Bug: 342097292
Test: KClassUtilTest
Change-Id: Ie04a62cb42e9d3e9a1badb4b66030851df22b01f

A room/room-runtime/src/androidInstrumentedTest/kotlin/NoPackageDatabase.kt
A room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/util/KClassUtilTest.kt
M room/room-runtime/src/jvmAndroidMain/kotlin/androidx/room/util/KClassUtil.jvmAndroid.kt

https://android-review.googlesource.com/3106237

da...@google.com <da...@google.com> #3Oct 24, 2018 04:12PM

Marked as fixed.

A fox for this issue will be available in Room 2.1.0-alpha02

ta...@gmail.com <ta...@gmail.com> #4Nov 13, 2018 12:00AM

I love foxes

https://media.giphy.com/media/Kt3lpGbEkM8i4/giphy.gif

[Deleted User] <[Deleted User]> #5Jan 2, 2019 01:55AM

delete

[Deleted User] <[Deleted User]> #6Jan 2, 2019 02:10AM