Illegal start of expression for Transaction without argument [117527454]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Oct 10, 2018 06:43AM

Component used: androidx.room:room-runtime, androidx.room:room-compiler
Version used: 2.0.0
Devices/Android versions reproduced on: N / A

@Dao
interface Foo {
@Query("SELECT * FROM bar")
fun getAll(): List<Bar>

@Transaction
fun getTransactionAll(): List<Bar> {
return getAll()
}
}

It generates

Foo.DefaultImpls.getTransactionAll(this, )

which cause the error (illegal start of expression) because of the extra comma.

Comments

yb...@google.com <yb...@google.com> Oct 10, 2018 03:55PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #2Oct 24, 2018 04:10PM

I guess technically, the ProGuard rule should be on androidx.work.NonBlockingWorker subclasses, but I'd also be okay with just not using reflection to access the Worker(Context, WorkerParamters) constructor and skipping the need for a ProGuard rule at all.

da...@google.com <da...@google.com> #3Oct 24, 2018 04:12PM

Marked as fixed.

Fixed in

https://android-review.googlesource.com/c/platform/frameworks/support/+/767262

ta...@gmail.com <ta...@gmail.com> #4Nov 13, 2018 12:00AM

The fix will be available in alpha10.

[Deleted User] <[Deleted User]> #5Jan 2, 2019 01:55AM

I tried to use the ProGuard configuration which is linked in

comment #3

in my project.
The release build fails and the following warnings are printed:

22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.NonBlockingWorker { NonBlockingWorker(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'
22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.NonBlockingWorker { void internalInit(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'
22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.Worker { Worker(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'

The app is opensource if you want to run the release build yourself. Here is the branch (WIP):

https://github.com/EventFahrplan/EventFahrplan/tree/workmanager
Please run: ./gradlew --info --debug aCcc34c3Release

[Deleted User] <[Deleted User]> #6Jan 2, 2019 02:10AM

Ah, that's because we have a typo in our Proguard file. Change WorkParameters to WorkerParameters.

Issue 117527454