Illegal start of expression for Transaction without argument [117527454]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Oct 10, 2018 06:43AM

Component used: androidx.room:room-runtime, androidx.room:room-compiler
Version used: 2.0.0
Devices/Android versions reproduced on: N / A

@Dao
interface Foo {
@Query("SELECT * FROM bar")
fun getAll(): List<Bar>

@Transaction
fun getTransactionAll(): List<Bar> {
return getAll()
}
}

It generates

Foo.DefaultImpls.getTransactionAll(this, )

which cause the error (illegal start of expression) because of the extra comma.

Comments

yb...@google.com <yb...@google.com> Oct 10, 2018 03:55PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #2Oct 24, 2018 04:10PM

since these are in public API (:/) we need to do this in 1.2

da...@google.com <da...@google.com> #3Oct 24, 2018 04:12PM

Marked as fixed.

since it is already marked as deprecated, we can probably do it by now.

ta...@gmail.com <ta...@gmail.com> #4Nov 13, 2018 12:00AM

Opening diff shortly

[Deleted User] <[Deleted User]> #5Jan 2, 2019 01:55AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

[Deleted User] <[Deleted User]> #6Jan 2, 2019 02:10AM

delete

Issue 117527454