Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 750d5cffec391b66aed177d8c4f1f5b75144f93a
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 23 21:47:16 2018
Remove the manifest registered graph API
These APIs conflict with programmatically inflated
NavGraphs with NavHostFragment and promote
unexpected global behavior.
Test: n/a
BUG: 118355937
Change-Id: If4ceca4d5e2c583ece06f1ecb5b047a970977fc7
M navigation/fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
https://android-review.googlesource.com/799722
https://goto.google.com/android-sha1/750d5cffec391b66aed177d8c4f1f5b75144f93a
Branch: androidx-master-dev
commit 750d5cffec391b66aed177d8c4f1f5b75144f93a
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 23 21:47:16 2018
Remove the manifest registered graph API
These APIs conflict with programmatically inflated
NavGraphs with NavHostFragment and promote
unexpected global behavior.
Test: n/a
BUG: 118355937
Change-Id: If4ceca4d5e2c583ece06f1ecb5b047a970977fc7
M navigation/fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
Description
Version used: 1.0.0-alpha06
Navigation has the ability to set a default graph from your manifest via NavController.setMetadataGraph() and NavInflater.inflateMetadataGraph().
The existence of this API promotes bad patterns (automatic defaults that reside far from the code invoking it) and can outright break other functionality such as setting a programmatically inflated NavGraph onto a NavHostFragment (as NavHostFragment will use the metadata graph by default, calling setGraph with the wrong graph).
These API should be removed entirely to prevent issues - developers should call NavHostFragment.create() or call setGraph() with exactly the graph they want.