Fixed
Status Update
No update yet.
Comments
il...@google.com
Yeah, it is our API issue. It is very unclear to developer that this will happen. Should we pass lifecycle as parameter?
gi...@gmail.com
IMO it is complicated issue/feature.
I see three possible use case scenarios:
1. Single actionBar/toolbar per activity. NavigationUI.setupWithNavController works fine.
2. Every fragment has its own toolbar. NavigationUI.setupWithNavController leaks views. And managing back arrow inside Toolbar is not necessary since it it not going to change.
3. Same toolbar used only for some fragments. Such case can occur when parent fragment has back stack with childFragmenManager.
I am not sure how to solve this best. If SDK user will pass fragmentLifecycle instead of viewLifeCycle then view is still be leaked for some time.
I decided not to use these methods at all because in my case (2nd) it is needed to update Toolbar only once - after Toolbar view create.
I see three possible use case scenarios:
1. Single actionBar/toolbar per activity. NavigationUI.setupWithNavController works fine.
2. Every fragment has its own toolbar. NavigationUI.setupWithNavController leaks views. And managing back arrow inside Toolbar is not necessary since it it not going to change.
3. Same toolbar used only for some fragments. Such case can occur when parent fragment has back stack with childFragmenManager.
I am not sure how to solve this best. If SDK user will pass fragmentLifecycle instead of viewLifeCycle then view is still be leaked for some time.
I decided not to use these methods at all because in my case (2nd) it is needed to update Toolbar only once - after Toolbar view create.
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d87596efaefed2570133a883d7c304e9ea95e7a8
Author: Ian Lake <ilake@google.com>
Date: Wed Aug 15 16:04:39 2018
Use WeakReferences in NavigationUI
Avoid storing a strong reference to views
(such as a Toolbar within a Fragment) in
OnNavigatedListeners created by
NavigationUI.
NavigationUI makes an effort to clean up
after itself by removing the
OnNavigatedListener if one of its
WeakReferences was garbage collected.
Test: ran the integration test app
BUG: 111961977
Change-Id: Iea466591cc77e79b3b056108d2818afe22d1ddc6
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
https://android-review.googlesource.com/732894
https://goto.google.com/android-sha1/d87596efaefed2570133a883d7c304e9ea95e7a8
Branch: androidx-master-dev
commit d87596efaefed2570133a883d7c304e9ea95e7a8
Author: Ian Lake <ilake@google.com>
Date: Wed Aug 15 16:04:39 2018
Use WeakReferences in NavigationUI
Avoid storing a strong reference to views
(such as a Toolbar within a Fragment) in
OnNavigatedListeners created by
NavigationUI.
NavigationUI makes an effort to clean up
after itself by removing the
OnNavigatedListener if one of its
WeakReferences was garbage collected.
Test: ran the integration test app
BUG: 111961977
Change-Id: Iea466591cc77e79b3b056108d2818afe22d1ddc6
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
il...@google.com
ap...@google.com
yes i tested it on
il...@google.com
We've renamed the listener to OnDestinationChangedListener to make it more clear that it is only called when NavController's getCurrentDestination() or its arguments change, precluding activity destinations.
Description
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on: HTC One, API 21
When the defined destination for an action in a given graph is another activity, the NavController.OnNavigatedListener registered for the origin Activity NavController is never called.
Although the new Activity has its own NavController, I think this navigation event is also relevant for the origin Activity NavController.