IssueTracker

Periods are technically valid characters in schemes as per https://tools.ietf.org/html/rfc3986#section-3.1 alongside the currently supported + and - characters, so it probably makes sense to add it as a supported character.

I take it your original request was just to note in the documentation that it wasn't supported?

I really would like to have it fixed.Because we have scheme with periods. I got used to it, by setting new pattern to the field. So for me it's ok now.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 59b75c42c73e4a6a9979207c702e6841e6665268
Author: Ian Lake <ilake@google.com>
Date:   Wed Oct 10 15:54:46 2018

    Regex escape NavDeepLinks
   
    Ensure that the only deep link regex like
    behavior are {argName} and .* blocks and treat
    all other characters as literals.
   
    This fixes issues with URLs with query parameters
    (where the ? is a special character) and allows
    us to support schemes with '+', -', and '.'
    characters as per
    https://tools.ietf.org/html/rfc3986#section-3.1
   
    Test: NavDeepLinkTest tests pass
    BUG: 110057514
    BUG: 112806402
    Change-Id: If621eb66ed3ca5e0da780c19b30068dd2824d461

M       navigation/common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M       navigation/common/src/main/java/androidx/navigation/NavDeepLink.java

https://android-review.googlesource.com/785556
https://goto.google.com/android-sha1/59b75c42c73e4a6a9979207c702e6841e6665268

The library now supports all schemes supported by https://tools.ietf.org/html/rfc3986#section-3.1

The regex being used is ^[a-zA-Z]+[+\w\-.]*:

Over to Studio to ensure that Manifest Merger also supports the updated schema types.

Yes, Manifest Merger supports this. Pending CL adds test for this scenario.

We've renamed the listener to OnDestinationChangedListener to make it more clear that it is only called when NavController's getCurrentDestination() or its arguments change, precluding activity destinations.