NavController.OnNavigatedListener not called when navigating to an activity destination [118670572]

Fixed

Feature Request

Status Update

No update yet.

Description

gi...@gmail.com

created issue #1

Oct 30, 2018 09:16PM

Component used: Navigation (fragment-ktx and ui-ktx packages)
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on: HTC One, API 21

When the defined destination for an action in a given graph is another activity, the NavController.OnNavigatedListener registered for the origin Activity NavController is never called.

Although the new Activity has its own NavController, I think this navigation event is also relevant for the origin Activity NavController.

Comments

il...@google.com <il...@google.com> #2Oct 30, 2018 09:26PM

Status: Won't Fix (Intended Behavior)

Project: platform/frameworks/support
Branch: androidx-main

commit 4945dfa31180f343697de5810b99ec80a48dc386
Author: Andrei Shikov <ashikov@google.com>
Date: Mon Jun 20 16:09:06 2022

Prevent removing derived state from composition when it is read in other scopes

Derived state observations were previously unconditionally removed from the recompose scope and composition together, which broke other scopes which might be still observing derived state.

This change only removes derived state instances if it is no longer observed by other scopes.

Fixes: 236618362
Test: CompositionAndDerivedStateTests#observingDerivedStateInMultipleScopes
Change-Id: I92e7c8702efecb33bea3ea3effe9ec47e2a6ae5b

M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composition.kt
M compose/runtime/runtime/src/commonTest/kotlin/androidx/compose/runtime/CompositionAndDerivedStateTests.kt

https://android-review.googlesource.com/2131915

gi...@gmail.com <gi...@gmail.com> #3Oct 31, 2018 09:11AM

The following release(s) address this bug:

androidx.compose.runtime:runtime:1.3.0

il...@google.com <il...@google.com> #4Nov 1, 2018 12:24AM

Assigned to il...@google.com.

Yeah, naming is hard :)

Right now, NavController.OnNavigatedListener gives you a NavDestination that always equals navController.getCurrentDestination(). It doesn't give you what action you triggered, arguments, or anything else (including operations that don't change getCurrentDestination(), such as singleTop actions or activity destinations), so I could definitely see this more as a OnDestinationChangedListener.

I'll reopen this to track renaming the listener to something more appropriate to what it actually is doing or updating the documentation to make its role more clear.

il...@google.com <il...@google.com> Nov 30, 2018 09:39PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #5Dec 3, 2018 09:13PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fcc0c6059e31f7e53396db8cce0ac62d76a1c2d8
Author: Ian Lake <ilake@google.com>
Date: Fri Nov 30 13:14:58 2018

Rename OnNavigatedListener

The callback to onNavigated() is not only
called in result to a navigate() call, but
is actually called whenever any navigation
event happens, be it single top navigation
events or popBackStack events.

Therefore the name should reflect what is
actually happening.

Test: existing tests still pass
BUG: 118670572
Change-Id: Iad45d646e859428a4f744992821916906ca2d34f

M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/NavigationActivity.kt
M navigation/runtime/api/1.0.0-alpha08.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnDestinationChangedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/ActionBarOnDestinationChangedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/CollapsingToolbarOnDestinationChangedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/ui/src/main/java/androidx/navigation/ui/ToolbarOnDestinationChangedListener.java

https://android-review.googlesource.com/838931

https://goto.google.com/android-sha1/fcc0c6059e31f7e53396db8cce0ac62d76a1c2d8

ap...@google.com <ap...@google.com> #6Dec 4, 2018 12:08AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1a5551e0e3145b1e309577a1282d28fa1b14e956
Author: Ian Lake <ilake@google.com>
Date: Mon Dec 03 13:22:31 2018

Correct naming of add/removeOnDestinationChangedListener

Ensure that the add and remove methods
use the same naming convention as the
listener class itself

Test: ./gradlew bOS
BUG: 118670572
Change-Id: I71dd174f7abd3a870c12b26c0aef64ff1512ceea

M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/NavigationActivity.kt
M navigation/runtime/api/1.0.0-alpha08.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnDestinationChangedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/CollapsingToolbarOnDestinationChangedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/ui/src/main/java/androidx/navigation/ui/ToolbarOnDestinationChangedListener.java

https://android-review.googlesource.com/839441

https://goto.google.com/android-sha1/1a5551e0e3145b1e309577a1282d28fa1b14e956

il...@google.com <il...@google.com> #7Dec 4, 2018 12:10AM

Marked as fixed.

We've renamed the listener to OnDestinationChangedListener to make it more clear that it is only called when NavController's getCurrentDestination() or its arguments change, precluding activity destinations.