NavController.OnNavigatedListener not called when navigating to an activity destination [118670572]

Fixed

Feature Request

Status Update

No update yet.

Description

gi...@gmail.com

created issue #1

Oct 30, 2018 09:16PM

Component used: Navigation (fragment-ktx and ui-ktx packages)
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on: HTC One, API 21

When the defined destination for an action in a given graph is another activity, the NavController.OnNavigatedListener registered for the origin Activity NavController is never called.

Although the new Activity has its own NavController, I think this navigation event is also relevant for the origin Activity NavController.

Comments

il...@google.com <il...@google.com> #2Oct 30, 2018 09:26PM

Status: Won't Fix (Intended Behavior)

Please attach a sample project that reproduces your issue.

gi...@gmail.com <gi...@gmail.com> #3Oct 31, 2018 09:11AM

Sure, here is a sample one at

https://github.com/Ethan1983/NavToolbarTitle. Steps are available in README.md

il...@google.com <il...@google.com> #4Nov 1, 2018 12:24AM

Assigned to il...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bd065925676170c8453321e970d455fac06b8d3d
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 28 15:47:16 2019

Add ProGuard rules for DrawerArrowDrawable.setProgress()

setProgress() is called via an ObjectAnimator and
therefore needs to be specifically kept when
obfuscating with ProGuard.

Test: tested in sample project attached to bug
Change-Id: I9c420ce728c5cb887d29df9f856bfd31f5bdbcdf
Fixes: 123449431

M navigation/ui/build.gradle
A navigation/ui/proguard-rules.pro

https://android-review.googlesource.com/887876

https://goto.google.com/android-sha1/bd065925676170c8453321e970d455fac06b8d3d

il...@google.com <il...@google.com> Nov 30, 2018 09:39PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #5Dec 3, 2018 09:13PM

We've added the appropriate ProGuard configuration and it'll be available in the next release.

As a workaround, you can add the following to your ProGuard configuration:

-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}

ap...@google.com <ap...@google.com> #6Dec 4, 2018 12:08AM

Sure, thanks for the quick fix.

il...@google.com <il...@google.com> #7Dec 4, 2018 12:10AM

Marked as fixed.

I had to use the androidx version for proguard rules

-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}