NavController.OnNavigatedListener not called when navigating to an activity destination [118670572]

Fixed

Feature Request

Status Update

No update yet.

Description

gi...@gmail.com

created issue #1

Oct 30, 2018 09:16PM

Component used: Navigation (fragment-ktx and ui-ktx packages)
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on: HTC One, API 21

When the defined destination for an action in a given graph is another activity, the NavController.OnNavigatedListener registered for the origin Activity NavController is never called.

Although the new Activity has its own NavController, I think this navigation event is also relevant for the origin Activity NavController.

Comments

il...@google.com <il...@google.com> #2Oct 30, 2018 09:26PM

Status: Won't Fix (Intended Behavior)

since these are in public API (:/) we need to do this in 1.2

gi...@gmail.com <gi...@gmail.com> #3Oct 31, 2018 09:11AM

since it is already marked as deprecated, we can probably do it by now.

il...@google.com <il...@google.com> #4Nov 1, 2018 12:24AM

Assigned to il...@google.com.

Opening diff shortly

il...@google.com <il...@google.com> Nov 30, 2018 09:39PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #5Dec 3, 2018 09:13PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

ap...@google.com <ap...@google.com> #6Dec 4, 2018 12:08AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1a5551e0e3145b1e309577a1282d28fa1b14e956
Author: Ian Lake <ilake@google.com>
Date: Mon Dec 03 13:22:31 2018

Correct naming of add/removeOnDestinationChangedListener

Ensure that the add and remove methods
use the same naming convention as the
listener class itself

Test: ./gradlew bOS
BUG: 118670572
Change-Id: I71dd174f7abd3a870c12b26c0aef64ff1512ceea

M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/NavigationActivity.kt
M navigation/runtime/api/1.0.0-alpha08.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnDestinationChangedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/CollapsingToolbarOnDestinationChangedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/ui/src/main/java/androidx/navigation/ui/ToolbarOnDestinationChangedListener.java

https://android-review.googlesource.com/839441

https://goto.google.com/android-sha1/1a5551e0e3145b1e309577a1282d28fa1b14e956

il...@google.com <il...@google.com> #7Dec 4, 2018 12:10AM

Marked as fixed.

We've renamed the listener to OnDestinationChangedListener to make it more clear that it is only called when NavController's getCurrentDestination() or its arguments change, precluding activity destinations.