Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 9febd8ad6b63dc1738f11d52333e9ca116735a2e
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 20 17:25:17 2022
Fix improper destination nesting with deep links
When deeplinking to a destination that has multiple nested nav_graphs,
the handleDeepLink() function will incorrectly remove the start
destinations of the parent NavGraphs when navigating to child graphs of
the parent.
What we really want is that you only pop and save destinations when
navigating to sibling graphs, not child graphs.
RelNote: "Intermediate start destinations will now be present when
deep linking through multiple nested `NavGraph`s."
Bug: 214383060
Test: tested in sample app in bug
Test: verified no regressions for other handleDeepLink cases
Change-Id: I504c04d2cc4381af22405266192ea0f5094f9c16
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/1956592
Branch: androidx-main
commit 9febd8ad6b63dc1738f11d52333e9ca116735a2e
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 20 17:25:17 2022
Fix improper destination nesting with deep links
When deeplinking to a destination that has multiple nested nav_graphs,
the handleDeepLink() function will incorrectly remove the start
destinations of the parent NavGraphs when navigating to child graphs of
the parent.
What we really want is that you only pop and save destinations when
navigating to sibling graphs, not child graphs.
RelNote: "Intermediate start destinations will now be present when
deep linking through multiple nested `NavGraph`s."
Bug: 214383060
Test: tested in sample app in bug
Test: verified no regressions for other handleDeepLink cases
Change-Id: I504c04d2cc4381af22405266192ea0f5094f9c16
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
Description
```
E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.jetpacknavigationtest, PID: 6203
java.lang.IllegalArgumentException: navigation destination com.example.jetpacknavigationtest:id/action_page1Fragment_to_page2Fragment is unknown to this NavController
at androidx.navigation.NavController.navigate(NavController.java:693)
at androidx.navigation.NavController.navigate(NavController.java:650)
at androidx.navigation.NavController.navigate(NavController.java:636)
at androidx.navigation.Navigation$1.onClick(Navigation.java:118)
at android.view.View.performClick(View.java:6294)
at android.view.View$PerformClick.run(View.java:24770)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
```
This may be related to
Component used:
android.arch.navigation:navigation-fragment-ktx:1.0.0-alpha07
android.arch.navigation:navigation-ui-ktx:1.0.0-alpha07
Version used:
Shown above
Devices/Android versions reproduced on:
Android_Accelerated_x86_Oreo.avd
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
Sample app:
Checkout /tree/1.0.0-alpha07
- A screenrecord or screenshots showing the issue (if UI related).