Use FragmentFactory to construct Fragments for NavHostFragment [119054429]

Fixed

Feature Request

Status Update

No update yet.

Description

ru...@gmail.com

created issue #1

Nov 6, 2018 01:50AM

Component used: AndroidX Fragment, Navigation
Version used: Fragment 1.1.0-alpha01, Nav 1.0.0-alpha07
Devices/Android versions reproduced on: All

When using FragmentFactory attached to a fragment manager, FragmentNavigator$Destination.createFragment() throws an "InstantiationException: <Fragment> has no zero argument constructor". It appears that upon creating the nav graph, NavHotsFragment instantiates fragments itself instead of delegating to the fragment manager.

Comments

il...@google.com <il...@google.com> #2Nov 16, 2018 07:12AM

Assigned to il...@google.com.

Status is still Assigned, but Compose 1.1.0 was already released. Did the ETA change for this feature?

il...@google.com <il...@google.com> Nov 26, 2018 05:53AM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #3Nov 26, 2018 06:15PM

The Compose Animation APIs Navigation needs (such as AnimatedContent) are still @Experimental in Compose 1.1.0.

il...@google.com <il...@google.com> #4Nov 26, 2018 06:33PM

Update: Same case for Compose 1.2.0

ru...@gmail.com <ru...@gmail.com> #5Nov 27, 2018 04:44PM

why is this taking so long?

[Deleted User] <[Deleted User]> #6Mar 5, 2019 05:21PM

seriously no update on what is stable?

il...@google.com <il...@google.com> Mar 8, 2019 09:58PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Mar 13, 2019 10:19PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #7Mar 14, 2019 05:15PM

Marked as fixed.

AnimatedContent is, as of today, still experimental and still cannot be used in androidx.navigation.

As soon as it is stable, we can kick off this work.

il...@google.com <il...@google.com> #8Mar 14, 2019 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit a3386225c952c42b7c687771ea31642d76f4df66
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 11:26:59 2023

Add Preview support in animated NavHost

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Change-Id: I7b017913d96e31785f16eb66534321d05f29b53d

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/2584844

[Deleted User] <[Deleted User]> #9Mar 15, 2019 10:31AM

Project: platform/frameworks/support
Branch: androidx-main

commit 256f919c6b8d579bc55e19d829aed438422f463b
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 10:48:32 2023

Migrate accompanist NavHost and NavController into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavHost and NavController now supports navigating in compose with Animations."
Change-Id: Ica95e794ef1794df4d1bdb38719b55624f832868

M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostControllerTest.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/2584843

ap...@google.com <ap...@google.com> #10Mar 18, 2019 06:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 682bae8ada2b2b29376003d55455230ff7320a69
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 15:13:14 2023

Migrate accompanist NavGraphBuilder into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavGraphBuilder now supports building composables and NavGraphs with transition animations."
Change-Id: I5ca9e22c8c3b02acaf80ddaa35b58ba7426c993a

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt

https://android-review.googlesource.com/2584842