IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bb5849831cc38dd1d229f2b80702b94d8f01de43
Author: Sumir Kataria <sumir@google.com>
Date:   Thu May 02 14:02:53 2019

    Correct some old terminology in PeriodicWorkRequest documentation.
   
    Fixes: 131711394
    Test: genDocs
    Change-Id: Ie8469aa34d02185c6fca9ed18a9ecf4d8bb3c81d

M       work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java

https://android-review.googlesource.com/954493
https://goto.google.com/android-sha1/bb5849831cc38dd1d229f2b80702b94d8f01de43

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1b215f0d93828286782776b9a12d2387097947f9
Author: Ian Lake <ilake@google.com>
Date:   Sun Nov 25 21:45:56 2018

    Move Fragment creation to FragmentNavigator
   
    Provide an instantiateFragment() method on
    FragmentNavigator which serves as the
    centralized place to instantiate new
    Fragment instances for FragmentNavigator.
   
    Besides moving this business logic out of
    the dumb POJO FragmentNavigator.Destination,
    this also provides a future extension point
    for integrating in FragmentFactory.
   
    Test: existing tests passes, testapp still works
    BUG: 119054429
    Change-Id: If60471a704ef77bc35b30838e152a31cde8bc235

M       navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilderTest.kt
M       navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilder.kt
M       navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M       navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/835682
https://goto.google.com/android-sha1/1b215f0d93828286782776b9a12d2387097947f9

Navigation still depends on Support Library and not AndroidX, so we can't directly use FragmentFactory in FragmentNavigator.

However, in alpha08, you'll be able to subclass FragmentNavigator and override instantiateFragment(), calling into FragmentFactory if you're using AndroidX Fragment 1.1.0+. You'd also need to subclass NavHostFragment and override createFragmentNavigator() to return your custom FragmentNavigator subclass (or, if you're not using app:navGraph, you can set it via navHostFragment.navController.navigatorProvider += YourFragmentNavigator(context, navHostFragment.childFragmentManager)).

We'll keep this open until Navigation has moved to AndroidX and can directly use FragmentFactory as its default implementation of instantiateFragment().

Thanks for the workaround in alpha08!

Can't wait to use this library after the move to AndroidX.
For us is a major blocking feature and we don't want to proceed overriding all the necessary classes.

Thank you Ian and the rest of the navigation team.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 74c3760e428648d00249dc1d38865b7802f48a9a
Author: Ian Lake <ilake@google.com>
Date:   Wed Mar 13 13:11:57 2019

    Use FragmentFactory in FragmentNavigator
   
    Rely on the FragmentManager's FragmentFactory
    to instantiate Fragments created for
    FragmentNavigator.
   
    Test: new FragmentNavigatorTest
    Fixes: 119054429
    Change-Id: Icbeb2771e29cafdc52e4c4ea770ce89f739921d1

M       navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M       navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/928481
https://goto.google.com/android-sha1/74c3760e428648d00249dc1d38865b7802f48a9a

This is fixed internally - FragmentNavigator will use the FragmentFactory to create Fragments in the upcoming 2.1.0-alpha01 release.

Thank you Ian :)

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3dd6d1fcdb3ffa7d4bd265a023f0ac7c94e14d19
Author: Ian Lake <ilake@google.com>
Date:   Mon Mar 18 09:36:37 2019

    Deprecate FragmentNavigator.instantiateFragment
   
    Instead of providing a custom subclass of
    FragmentNavigator, instantiation of Fragments
    should be controlled by setting a custom
    FragmentFactory, which is the default behavior
    of instantiateFragment() now.
   
    By deprecating the class, we ensure that
    developers who were overriding this method
    are informed of the changes and can change
    their code to use FragmentFactory.
   
    Test: ./gradlew checkApi
    BUG: 119054429
    Change-Id: Iff46919face98baa6dc62835ca3fc105d987d141

M       navigation/fragment/api/2.1.0-alpha01.txt
M       navigation/fragment/api/current.txt
M       navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/930120
https://goto.google.com/android-sha1/3dd6d1fcdb3ffa7d4bd265a023f0ac7c94e14d19