android.net.ConnectivityManager in unregisterNetworkCallback [119484416]

Fixed

Bug

Status Update

No update yet.

Description

su...@yahooinc.com

created issue #1

Nov 13, 2018 08:33PM

Component used: Workmanager
Version used: Alpha 10
Devices/Android versions reproduced on: Nvidia (100%)

stacktrace:

ConnectivityManager.java in android.net.ConnectivityManager.unregisterNetworkCallback at line 3106
NetworkStateTracker.java in androidx.work.impl.constraints.trackers.NetworkStateTracker.stopTracking at line 94
ConstraintTracker.java in androidx.work.impl.constraints.trackers.ConstraintTracker.removeListener at line 79
ConstraintController.java in androidx.work.impl.constraints.controllers.ConstraintController.replace at line 98
GreedyScheduler.java in androidx.work.impl.background.greedy.GreedyScheduler.removeConstraintTrackingFor at line 150
Processor.java in androidx.work.impl.Processor.onExecuted at line 228
Processor.java in androidx.work.impl.Processor$FutureListener.run at line 258
Handler.java in android.os.Handler.handleCallback at line 751
Handler.java in android.os.Handler.dispatchMessage at line 95
Looper.java in android.os.Looper.loop at line 154
ActivityThread.java in android.app.ActivityThread.main at line 6120
java.lang.reflect.Method in invoke
ZygoteInit.java in com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run at line 865
ZygoteInit.java in com.android.internal.os.ZygoteInit.main at line 755

Comments

su...@google.com <su...@google.com> #2Nov 14, 2018 12:50AM

I forgot to mention that my Woker returns Result.SUCCESS always.

su...@yahooinc.com <su...@yahooinc.com> #3Nov 14, 2018 12:58AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 05f2d67cc04c5f76bee122b9e1e23ca1bf61a326
Author: Sumir Kataria <sumir@google.com>
Date: Tue Aug 21 16:36:05 2018

Fix periodic work so it executes repeatedly.

Processor.onExecuted is the wrong place for cancelling things in
other schedulers. It doesn't have the proper information about
what needs to be cancelled. For example, PeriodicWork should NOT
be cancelled. This should be done right before Schedulers.schedule
at the end of WorkerWrapper.

Bug: 112859683
Test: Added new tests for API 22-, manually tested using
integration app for 23+ since JobScheduler enforces a 15 minute
limit between executions

Change-Id: Ia0e6e17367fbc2493339b9b1275453267c571580

M work/workmanager/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/workmanager/src/main/java/androidx/work/impl/Processor.java
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java

https://android-review.googlesource.com/735827

https://goto.google.com/android-sha1/05f2d67cc04c5f76bee122b9e1e23ca1bf61a326

su...@google.com <su...@google.com> #4Nov 14, 2018 01:09AM

I am experiencing the same problem using the following code:

val myWorker = PeriodicWorkRequestBuilder<MyWorker>(15, TimeUnit.MINUTES)

myWorker.addTag(NEWSFEED_SYNC_WORKER_ID)

val constraints = Constraints.Builder()
.setRequiredNetworkType(NetworkType.CONNECTED)
.build()
myWorker.setConstraints(constraints)

WorkManager.getInstance().enqueue(myWorker.build())

su...@yahooinc.com <su...@yahooinc.com> #5Nov 14, 2018 05:45AM

The fix will be available in alpha08.

su...@google.com <su...@google.com> #6Nov 14, 2018 09:08PM

I'm facing this in alpha09 on Android Pie

su...@yahooinc.com <su...@yahooinc.com> #7Nov 14, 2018 09:56PM

Update: alpha09 works fine in pre-Oreo with a minimum interval of 15 minutes. Post Oreo, never gets triggered. Haven't yet checked the interference of battery optimization. Will update on the same soon.

ap...@google.com <ap...@google.com> #8Nov 15, 2018 11:53PM

Still facing this in alpha10 on Oreo and Pie

su...@google.com <su...@google.com> Nov 15, 2018 11:54PM

Marked as fixed, reassigned to su...@google.com.