android.net.ConnectivityManager in unregisterNetworkCallback [119484416]

Fixed

Bug

Status Update

No update yet.

Description

su...@yahooinc.com

created issue #1

Nov 13, 2018 08:33PM

Component used: Workmanager
Version used: Alpha 10
Devices/Android versions reproduced on: Nvidia (100%)

stacktrace:

ConnectivityManager.java in android.net.ConnectivityManager.unregisterNetworkCallback at line 3106
NetworkStateTracker.java in androidx.work.impl.constraints.trackers.NetworkStateTracker.stopTracking at line 94
ConstraintTracker.java in androidx.work.impl.constraints.trackers.ConstraintTracker.removeListener at line 79
ConstraintController.java in androidx.work.impl.constraints.controllers.ConstraintController.replace at line 98
GreedyScheduler.java in androidx.work.impl.background.greedy.GreedyScheduler.removeConstraintTrackingFor at line 150
Processor.java in androidx.work.impl.Processor.onExecuted at line 228
Processor.java in androidx.work.impl.Processor$FutureListener.run at line 258
Handler.java in android.os.Handler.handleCallback at line 751
Handler.java in android.os.Handler.dispatchMessage at line 95
Looper.java in android.os.Looper.loop at line 154
ActivityThread.java in android.app.ActivityThread.main at line 6120
java.lang.reflect.Method in invoke
ZygoteInit.java in com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run at line 865
ZygoteInit.java in com.android.internal.os.ZygoteInit.main at line 755

Comments

su...@google.com <su...@google.com> #2Nov 14, 2018 12:50AM

Navigation is built with Support Library Fragments so has no access to the FragmentFactory itself. I think we can make some minor changes to FragmentNavigator to make it easy for developers who are using Navigation 1.0 and Fragments 1.1.0 together to call through to their FragmentFactory.

Once Navigation switches to AndroidX (post 1.0), we'll use FragmentFactory directly.

su...@yahooinc.com <su...@yahooinc.com> #3Nov 14, 2018 12:58AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1b215f0d93828286782776b9a12d2387097947f9
Author: Ian Lake <ilake@google.com>
Date: Sun Nov 25 21:45:56 2018

Move Fragment creation to FragmentNavigator

Provide an instantiateFragment() method on
FragmentNavigator which serves as the
centralized place to instantiate new
Fragment instances for FragmentNavigator.

Besides moving this business logic out of
the dumb POJO FragmentNavigator.Destination,
this also provides a future extension point
for integrating in FragmentFactory.

Test: existing tests passes, testapp still works
BUG: 119054429
Change-Id: If60471a704ef77bc35b30838e152a31cde8bc235

M navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilderTest.kt
M navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilder.kt
M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/835682

https://goto.google.com/android-sha1/1b215f0d93828286782776b9a12d2387097947f9

su...@google.com <su...@google.com> #4Nov 14, 2018 01:09AM

Navigation still depends on Support Library and not AndroidX, so we can't directly use FragmentFactory in FragmentNavigator.

However, in alpha08, you'll be able to subclass FragmentNavigator and override instantiateFragment(), calling into FragmentFactory if you're using AndroidX Fragment 1.1.0+. You'd also need to subclass NavHostFragment and override createFragmentNavigator() to return your custom FragmentNavigator subclass (or, if you're not using app:navGraph, you can set it via navHostFragment.navController.navigatorProvider += YourFragmentNavigator(context, navHostFragment.childFragmentManager)).

We'll keep this open until Navigation has moved to AndroidX and can directly use FragmentFactory as its default implementation of instantiateFragment().

su...@yahooinc.com <su...@yahooinc.com> #5Nov 14, 2018 05:45AM

Thanks for the workaround in alpha08!

su...@google.com <su...@google.com> #6Nov 14, 2018 09:08PM

Can't wait to use this library after the move to AndroidX.
For us is a major blocking feature and we don't want to proceed overriding all the necessary classes.

Thank you Ian and the rest of the navigation team.

su...@yahooinc.com <su...@yahooinc.com> #7Nov 14, 2018 09:56PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 74c3760e428648d00249dc1d38865b7802f48a9a
Author: Ian Lake <ilake@google.com>
Date: Wed Mar 13 13:11:57 2019

Use FragmentFactory in FragmentNavigator

Rely on the FragmentManager's FragmentFactory
to instantiate Fragments created for
FragmentNavigator.

Test: new FragmentNavigatorTest
Fixes: 119054429
Change-Id: Icbeb2771e29cafdc52e4c4ea770ce89f739921d1

M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/928481

https://goto.google.com/android-sha1/74c3760e428648d00249dc1d38865b7802f48a9a

ap...@google.com <ap...@google.com> #8Nov 15, 2018 11:53PM

This is fixed internally - FragmentNavigator will use the FragmentFactory to create Fragments in the upcoming 2.1.0-alpha01 release.

su...@google.com <su...@google.com> Nov 15, 2018 11:54PM

Marked as fixed, reassigned to su...@google.com.