android.net.ConnectivityManager in unregisterNetworkCallback [119484416]

Fixed

Bug

Status Update

No update yet.

Description

su...@yahooinc.com

created issue #1

Nov 13, 2018 08:33PM

Component used: Workmanager
Version used: Alpha 10
Devices/Android versions reproduced on: Nvidia (100%)

stacktrace:

ConnectivityManager.java in android.net.ConnectivityManager.unregisterNetworkCallback at line 3106
NetworkStateTracker.java in androidx.work.impl.constraints.trackers.NetworkStateTracker.stopTracking at line 94
ConstraintTracker.java in androidx.work.impl.constraints.trackers.ConstraintTracker.removeListener at line 79
ConstraintController.java in androidx.work.impl.constraints.controllers.ConstraintController.replace at line 98
GreedyScheduler.java in androidx.work.impl.background.greedy.GreedyScheduler.removeConstraintTrackingFor at line 150
Processor.java in androidx.work.impl.Processor.onExecuted at line 228
Processor.java in androidx.work.impl.Processor$FutureListener.run at line 258
Handler.java in android.os.Handler.handleCallback at line 751
Handler.java in android.os.Handler.dispatchMessage at line 95
Looper.java in android.os.Looper.loop at line 154
ActivityThread.java in android.app.ActivityThread.main at line 6120
java.lang.reflect.Method in invoke
ZygoteInit.java in com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run at line 865
ZygoteInit.java in com.android.internal.os.ZygoteInit.main at line 755

Comments

su...@google.com <su...@google.com> #2Nov 14, 2018 12:50AM

Or when changing to textView.textMetricsParamsCompat still crash.

private fun setAsyncText(textView: AppCompatTextView, text: String?) {
if (!text.isNullOrEmpty()) {
val textFuture = PrecomputedTextCompat.getTextFuture(text!!, textView.textMetricsParamsCompat, null)
textView.setTextFuture(textFuture) //Crash
}
}

su...@yahooinc.com <su...@yahooinc.com> #3Nov 14, 2018 12:58AM

add this line :
textView.setLayoutDirection(ViewCompat.getLayoutDirection(textView));
before :
setTextFuture(....)

su...@google.com <su...@google.com> #4Nov 14, 2018 01:09AM

Thanks, #3. It worked.

But I think it is better when set before this line
val textFuture = PrecomputedTextCompat.getTextFuture(text!!, textView.textMetricsParamsCompat, null)

Set android:layoutDirection="locale" or android:layoutDirection="inherit" for AppCompatTextView in the XML layout didn't this problem.

The new method btw re-set layoutDirector. Weird! This should handle in the AppcompatTextView.

private fun setAsyncText(textView: AppCompatTextView, text: String?) {
if (!text.isNullOrEmpty()) {
textView.layoutDirection = textView.layoutDirection
val textFuture = PrecomputedTextCompat.getTextFuture(text!!, textView.textMetricsParamsCompat, null)
textView.setTextFuture(textFuture) //Crash
}
}

su...@yahooinc.com <su...@yahooinc.com> #5Nov 14, 2018 05:45AM

Sorry. I forgot the info.

minSdk 21
targetSdk 28

Thanks #3 again.

su...@google.com <su...@google.com> #6Nov 14, 2018 09:08PM

App Crash at
TextViewCompat.java:889
if (!param.equals(precomputed.getParams())) {
throw new IllegalArgumentException("Given text can not be applied to TextView.");
}
PrecomputedTextCompat.class:334
with : this.mTextDir != other.getTextDirection() == true
So,
TextDirection on TextView and TextDirection on Param is difference
maybe, it handled wrong or missing conditional on getTextDirectionHeuristic of TextViewCompat

su...@yahooinc.com <su...@yahooinc.com> #7Nov 14, 2018 09:56PM

With reference to

comment #4

, issue is resolved by implementing suggested changes in

comment #3

. Can you please confirm if we need to still investigate this issue ?

ap...@google.com <ap...@google.com> #8Nov 15, 2018 11:53PM

Yes. textView.layoutDirection = textView.layoutDirection(>= API17) or ViewCompat.setLayoutDirection(textView, ViewCompat.getLayoutDirection(textView)) will resolve this bug.

But I think you should handle it in the AppcompatTextView. It is better. If a developer forgets testing with RTL. I think this is the nightmare(it is difficult to determine the bug) when they update their app on the Play Store.

I read this article, in the part databing he noted about set the direction

https://medium.com/google-developers/prefetch-text-layout-in-recyclerview-4acf9103f438'

fun asyncText
..........
// first, set all measurement affecting properties of the text
// (size, locale, typeface, direction, etc)

But in the offical document isn't good (lack direction)

https://developer.android.com/reference/androidx/appcompat/widget/AppCompatTextView.html#setTextFuture(java.util.concurrent.Future%3Candroidx.core.text.PrecomputedTextCompat%3E)

Anything layout related property changes, text size, typeface, letter spacing, etc after this method call will causes IllegalArgumentException during View measurement.

My view: Handling this in the AppcompatTextView is the best choice if you can do it.

Thanks!

su...@google.com <su...@google.com> Nov 15, 2018 11:54PM

Marked as fixed, reassigned to su...@google.com.