Remove the deprecated clearTask and launchDocument flags from NavOptions [119628354]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

Nov 15, 2018 09:36PM

Component used: Navigation
Version used: 1.0.0-alpha07

The clearTask and launchDocument flags and attributes have been deprecated for a number of releases - they should be removed.

Comments

il...@google.com <il...@google.com> Nov 15, 2018 09:45PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #2Nov 15, 2018 11:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1381476

ap...@google.com <ap...@google.com> #3Nov 16, 2018 12:02AM

This has been fixed internally and will be available in the Navigation 2.4.0-alpha01 release.

il...@google.com <il...@google.com> Nov 16, 2018 12:13AM

Marked as fixed.

pe...@gmail.com <pe...@gmail.com> #4Dec 10, 2018 03:25AM

Thank you, that's great to hear. Looking forward to it.

lo...@gmail.com <lo...@gmail.com> #5Dec 11, 2018 04:34PM

Project: platform/frameworks/support
Branch: snap-temp-L69500000699825513

commit 91e0659733e097aabfb5801caccbf6f40d2f4a72
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436153

pe...@gmail.com <pe...@gmail.com> #6Dec 12, 2018 04:03AM

Project: platform/frameworks/support
Branch: snap-temp-L62000000699827533

commit 94827a2939f3a4d2c8d08e8dc93d53330de56806
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436736