androidx.navigation.safeargs sync fail on Android Studio 3.4 Canary 4 in a baseFeature module [119662045]

Fixed

Bug

Status Update

No update yet.

Description

vi...@gmail.com

created issue #1

Nov 16, 2018 06:48PM

Component used: android.arch.navigation:navigation-safe-args-gradle-plugin
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on:
- Android Studio 3.4 Canary 4
- Multi features app (with instant app)
- Using apply plugin: 'androidx.navigation.safeargs' in a baseFeature module.

Error:
ERROR: variant.getApplicationId() is not supported by feature plugins as it cannot handle delayed setting of the application ID. Please use getApplicationIdTextResource() instead.
Affected Modules: base

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Follow this instructions:
- Clone the official googlesamples android-instant-apps

https://github.com/googlesamples/android-instant-apps
- Open the multi-feature-module project with Android Studio 3.4 Canary 4
- Add android.arch.navigation to the project :

multi-feature-module build.gradle:
[…]
buildscript {
repositories {
jcenter()
google()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.4.0-alpha04'
classpath 'android.arch.navigation:navigation-safe-args-gradle-plugin:1.0.0-alpha07'
}
}
[…]

base build.gradle:
apply plugin: 'com.android.feature'
apply plugin: 'androidx.navigation.safeargs'

android {
[…]

- sync gradle files and you get the error:
ERROR: variant.getApplicationId() is not supported by feature plugins as it cannot handle delayed setting of the application ID. Please use getApplicationIdTextResource() instead.
Affected Modules: base

Comments

il...@google.com <il...@google.com> Nov 16, 2018 07:07PM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #2Nov 19, 2018 11:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 44991c9a6f7d832decb7a19b9d795f8644bc8503
Author: jbwoods <jbwoods@google.com>
Date: Fri Mar 15 10:58:23 2019

Add NavDirections overload for createOnClickListener in Navigation

Gives developers the convenient option of just passing navDirections to
createOnClickListener instead of manually exactings the ActionID and
Bundle.

Test: ./gradlew checkApi
BUG: 127631752
Change-Id: Icfc3762570ccf5efac83afc0375cbdb8c0acee11

M navigation/runtime/api/2.1.0-alpha01.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/Navigation.java

https://android-review.googlesource.com/930453

https://goto.google.com/android-sha1/44991c9a6f7d832decb7a19b9d795f8644bc8503

vi...@gmail.com <vi...@gmail.com> #3Dec 13, 2018 04:31PM

This has been added internally and will be available in Navigation 2.1.0-alpha01

da...@google.com <da...@google.com> #4Dec 13, 2018 05:10PM

A fix for this issue will be available in alpha09

il...@google.com <il...@google.com> #5Dec 13, 2018 06:38PM

Marked as fixed.

For exact reference, this was fixed in

https://android-review.googlesource.com/845025

or...@gmail.com <or...@gmail.com> #6Dec 31, 2018 07:30PM

Am using alpha09 here (had been seeing issue mentioned above before updating)....but not getting following during gradle sync. I'm using Android Studio 3.4 Canary 9 (but also had same problem using 3.3 RC3)

Caused by: kotlin.TypeCastException: null cannot be cast to non-null type org.gradle.api.resources.TextResource
at androidx.navigation.safeargs.gradle.SafeArgsPlugin.setApplicationId(SafeArgsPlugin.kt:87)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin.access$setApplicationId(SafeArgsPlugin.kt:39)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1$task$1.execute(SafeArgsPlugin.kt:63)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1$task$1.execute(SafeArgsPlugin.kt:39)
at org.gradle.api.internal.tasks.DefaultTaskContainer.create(DefaultTaskContainer.java:360)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1.invoke(SafeArgsPlugin.kt:59)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1.invoke(SafeArgsPlugin.kt:39)
at androidx.navigation.safeargs.gradle.SafeArgsPluginKt$sam$org_gradle_api_Action$0.execute(SafeArgsPlugin.kt)
at org.gradle.internal.ImmutableActionSet$SingletonSet.execute(ImmutableActionSet.java:225)
at org.gradle.api.internal.DefaultDomainObjectCollection.doAdd(DefaultDomainObjectCollection.java:247)
at org.gradle.api.internal.DefaultDomainObjectCollection.add(DefaultDomainObjectCollection.java:236)
at com.android.build.gradle.LibraryExtension.addVariant(LibraryExtension.java:93)
at com.android.build.gradle.FeatureExtension.addVariant(FeatureExtension.java:121)
at com.android.build.gradle.internal.ApiObjectFactory.create(ApiObjectFactory.java:134)

or...@gmail.com <or...@gmail.com> #7Dec 31, 2018 07:30PM

that should read - "but now getting following...."1

da...@google.com <da...@google.com> #8Jan 9, 2019 05:30PM

We are aware of the error mentioned in #6, see

https://issuetracker.google.com/issues/121304903