Fixed
Status Update
No update yet.
Comments
il...@google.com
da...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4fc8470745f5b0f08f9531b7ab85eed6a8f424cb
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jun 10 11:26:54 2021
Remove uses of titleCase in Safe Args
The titleCase API was added in Kotlin 1.5.0. Gradle versions previous to
7.0 relied on eariler versionss of Kotlin that do not have that API
available. SafeArgs now depends on Android Gradle Plugin 4.2.0, which is
compatible down to Gradle 6.7.1, so we should continue to support older
versions of kotlin until we move to the next stable version of AGP.
RelNote: "SafeArgs will no longer fail when building your app with
`Kotlin` versions before `1.5.0`."
Test: tested in sample app
Bug: 190739257
Change-Id: Icd1ff3c64f220f4b310934c2edf910d6aae01475
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/ext/String_ext.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/NavArgumentResolverTest.kt
https://android-review.googlesource.com/1733983
Branch: androidx-main
commit 4fc8470745f5b0f08f9531b7ab85eed6a8f424cb
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jun 10 11:26:54 2021
Remove uses of titleCase in Safe Args
The titleCase API was added in Kotlin 1.5.0. Gradle versions previous to
7.0 relied on eariler versionss of Kotlin that do not have that API
available. SafeArgs now depends on Android Gradle Plugin 4.2.0, which is
compatible down to Gradle 6.7.1, so we should continue to support older
versions of kotlin until we move to the next stable version of AGP.
RelNote: "SafeArgs will no longer fail when building your app with
`Kotlin` versions before `1.5.0`."
Test: tested in sample app
Bug: 190739257
Change-Id: Icd1ff3c64f220f4b310934c2edf910d6aae01475
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/ext/String_ext.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/NavArgumentResolverTest.kt
il...@google.com
il...@google.com
This is fixed internally and will be available in the the Navigation 2.4.0-alpha04 release.
Description
Version used:1.0.0-alpha07
Devices/Android versions reproduced on: Emulator API 28, Xiaomi MI A1 8.1 (Android One)
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue. - ATTACHED
Clicking on a Notification with PendingIntent created by NavDeepLinkBuilder uses the arguments of the last Notification created. For example: If you created notifications with fragment arguments 1, 2 and 3, then no matter which notification you click on, the fragment is started with argument 3.