Fixed
Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Remove android specific NavControllerViewModel
Expand for full commit details
Remove android specific NavControllerViewModel
Everything in NavControllerViewModel is common API so we don't need an
Android version. Moving that code to common.
Test: all tests pass
Bug: 403616316
Change-Id: Ibe154b2d04adc0a536f9a5e170cc8fbb44ed1bcf
Files:
- D
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavControllerViewModel.android.kt - M
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavControllerViewModel.kt
Hash: 3bb40a6be709d8c7e13f56f248a6433154aec72e
Date: Fri Mar 14 21:37:30 2025
il...@google.com
il...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Implement nonAndroid NavType
Expand for full commit details
Implement nonAndroid NavType
Moving call common implementation of NavType to commonMain and then
allow both the nonAndroid and Android implementation to use them.
Test: all tests pass
Bug: 403616316
Change-Id: I297d8846859aaa719b179c7e69e993d0d6e28fd6
Files:
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavType.android.kt - M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavType.kt - M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavType.nonAndroid.kt
Hash: 8f968ddbb3b8296af2033db4cf2658255fa43853
Date: Fri Mar 14 22:41:34 2025
Description
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on:
ActivityNavigator only supports string arguments for filling in the data pattern. It should at least use toString() on any type of argument.