AndroidX compilation failure: "cannot generate view binders: Stream closed" [120277395]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

ku...@gmail.com

created issue #1

Nov 30, 2018 08:08PM

After migrating to AndroidX, we are seeing a transient build failure during our library module's compileDebugJavaWithJava task. It seems to be a race condition when multiple modules with data binding enabled are compiling in parallel.

Tested on AGP: 3.2.0

error: cannot generate view binders java.io.IOException: Stream closed
at java.util.zip.InflaterInputStream.ensureOpen(InflaterInputStream.java:67)
at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:142)
at java.io.FilterInputStream.read(FilterInputStream.java:133)
at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
at java.io.InputStreamReader.read(InputStreamReader.java:184)
at java.io.Reader.read(Reader.java:140)
at kotlin.io.TextStreamsKt.copyTo(ReadWrite.kt:122)
at kotlin.io.TextStreamsKt.copyTo$default(ReadWrite.kt:115)
at kotlin.io.TextStreamsKt.readText(ReadWrite.kt:102)
at com.android.tools.build.jetifier.core.config.ConfigParser.loadDefaultConfig(ConfigParser.kt:54)
at android.databinding.tool.LibTypes$typeRewriter$2.invoke(LibTypes.kt:30)
at android.databinding.tool.LibTypes$typeRewriter$2.invoke(LibTypes.kt:23)
at kotlin.UnsafeLazyImpl.getValue(Lazy.kt:154)
at android.databinding.tool.LibTypes.getTypeRewriter(LibTypes.kt)
at android.databinding.tool.LibTypes.convert(LibTypes.kt:179)
at android.databinding.tool.LibTypes$nonNull$2.invoke(LibTypes.kt:117)
at android.databinding.tool.LibTypes$nonNull$2.invoke(LibTypes.kt:23)
at kotlin.UnsafeLazyImpl.getValue(Lazy.kt:154)
at android.databinding.tool.LibTypes.getNonNull(LibTypes.kt)
at android.databinding.tool.writer.LayoutBinderWriter$write$1.invoke(LayoutBinderWriter.kt:350)
at android.databinding.tool.writer.LayoutBinderWriter$write$1.invoke(LayoutBinderWriter.kt:315)
at android.databinding.tool.writer.KCodeKt.kcode(KCode.kt:172)
at android.databinding.tool.writer.LayoutBinderWriter.write(LayoutBinderWriter.kt:347)
at android.databinding.tool.LayoutBinder.writeViewBinder(LayoutBinder.java:360)
at android.databinding.tool.DataBinder.writeBinders(DataBinder.java:137)

Comments

rm...@google.com <rm...@google.com> #2Dec 5, 2018 06:24AM

Assigned to rm...@google.com.

This mentioned interface was removed only starting 7.2, so you shouldn't have problems with using firebase with AGP 7.1. Are you sure you don't have a dependency somewhere (maybe buildSrc?) on AGP or just gradle-api 7.2?

ku...@gmail.com <ku...@gmail.com> #3Dec 5, 2018 07:15PM

I checked the project and there is no reference to AGP 7.2
I looked in ~/.gradle/caches/modules-2/files-2.1/com.android.tools.build/gradle-api and ~/.gradle/caches/modules-2/files-2.1/com.android.tools.build/gradle

Only 7.1.0-beta04 and 7.1.0-beta05 is there.

I checked with a new project. This problem only occurs when I enable the com.google.gms.google-services
and com.google.firebase.firebase-perf plugin.
Without these plugins everything works fine.

rm...@google.com <rm...@google.com> Dec 10, 2018 06:48AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> Jan 7, 2019 07:20PM

Reassigned to di...@google.com.

zh...@gmail.com <zh...@gmail.com> #4Feb 1, 2019 06:16PM

This is a known issue, we are working with those teams so they release a compatible plugin.

di...@google.com <di...@google.com> Feb 4, 2019 02:47PM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> #5Feb 4, 2019 05:07PM

Thanks!

yb...@google.com <yb...@google.com> #6Feb 4, 2019 05:12PM

Reassigned to pa...@google.com.

When can we expect an update on this?

pa...@google.com <pa...@google.com> #7Feb 4, 2019 07:10PM

Reassigned to yb...@google.com.

Last communication from firebase-perf team stated a release is scheduled for this week.

yb...@google.com <yb...@google.com> #8Feb 4, 2019 10:18PM

Reassigned to pa...@google.com.

But it looks like not only perf but androidx.navigation.safeargs.gradle.SafeArgsPlugin also has this issue.

pa...@google.com <pa...@google.com> #9Feb 5, 2019 11:21AM

Yep, androidx.navigation.safeargs.gradle.SafeArgsPlugin seems to be an issue too.

pa...@google.com <pa...@google.com> #10Feb 5, 2019 11:45AM

Reassigned to yb...@google.com.

When can we expect an update concerning the safeargs Plugin?

hu...@google.com <hu...@google.com> #11Feb 5, 2019 02:35PM

Marked as fixed.

safegargs will be fixed with the next jetpack release which is currently scheduled for end of January.

sorry it is taking so long, the holidays have delayed many releases.

dr...@gmail.com <dr...@gmail.com> #12Feb 5, 2019 05:42PM

firebase perf still has the issue, but I just removed that plugin for now as it requires no app side changes. instead I just commented it out. google-services 4.3.10 does not seem to be an issue.

I was able to get by the nav plugin issue by using a new snapshot:

buildscript {
  repositories {
    google()
    mavenCentral()
    maven("https://androidx.dev/snapshots/builds/8054565/artifacts/repository")
  }
}

then update the plugin to

classpath("androidx.navigation:navigation-safe-args-gradle-plugin:2.5.0-SNAPSHOT")

I don't know whether I should update the rest of my nav deps to 2.5.0 snapshot, but this'll do for now.

hu...@google.com <hu...@google.com> #13Feb 8, 2019 02:19PM

Status: Assigned (reopened)

Firebase has published perf-plugin 1.4.1 which includes the fix to this issue

hu...@google.com <hu...@google.com> #14Mar 7, 2019 11:07AM

Marked as fixed.

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 2 (2021.3.1.2)
Android Gradle Plugin 7.3.0-alpha02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ku...@gmail.com <ku...@gmail.com> #15Apr 29, 2019 08:11PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 5 (2021.3.1.5)
Android Gradle Plugin 7.3.0-alpha05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

je...@google.com <je...@google.com> #16Apr 29, 2019 09:14PM

Status: Assigned (reopened)

I have a same problem in firebase plese solve the problem

hu...@google.com <hu...@google.com> #17Apr 30, 2019 11:39AM

Reassigned to pa...@google.com.

read #13

ap...@google.com <ap...@google.com> #18Apr 30, 2019 05:49PM

same issue

pa...@google.com <pa...@google.com> #19Apr 30, 2019 05:50PM

Reassigned to hu...@google.com.

This issue was already fixed, please upgrade your firebase perf plugin to 1.4.1 or later

hu...@google.com <hu...@google.com> #20May 3, 2019 02:36PM

Thanks Filip, I'll update the AGP to use the new Jetifier version once it's released.

da...@spotify.com <da...@spotify.com> #21May 10, 2019 06:47PM

You might be able to take some inspiration from here:

https://github.com/google/auto/commit/0cced0d4a09ffe01f1c315672b722a66631b72f5
AutoValue had a similar issue that I and Eamonn tracked down.

me...@gmail.com <me...@gmail.com> #22May 22, 2019 09:09PM

Is this fix pushed in AGP 3.5 beta ?

hu...@google.com <hu...@google.com> #23May 24, 2019 04:30PM

@21: Thanks a lot for the suggestion!

@22: Not yet, because the new Jetifier version with the (speculative) fix is not released yet.

hu...@google.com <hu...@google.com> #24Jun 7, 2019 09:06PM

Reassigned to pa...@google.com.

FYI, the Jetifier release is still pending:

https://android-review.googlesource.com/c/platform/frameworks/support/+/954838

@Filip: Please reassign back to me once it is released.

ja...@gmail.com <ja...@gmail.com> #25Jun 11, 2019 11:34PM

Any updates here? Is there a chance this will make it into AGP 3.5, given that we're on beta 4 now?

hu...@google.com <hu...@google.com> #26Jul 1, 2019 04:58PM

Reassigned to hu...@google.com.

Jetifier 1.0.0-beta05 has been released. To use it, you can add the following to your build.gradle file:

buildscript {
repositories { ...
}
dependencies { ...
classpath 'com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta05'
}
}

Please let us know if you still run into this issue after updating Jetifier. That will confirm whether this issue is actually caused by Jetifier or not.

hu...@google.com <hu...@google.com> #27Jul 1, 2019 05:01PM

@25: We will integrate Jetifier 1.0.0-beta05 into the coming 3.6 canaries of the AGP, it's too late for 3.5 now.

ku...@gmail.com <ku...@gmail.com> #28Jul 16, 2019 06:15PM

After manually bumping to Jetifier to 1.0.0-beta05 manually in our build, we are still seeing the failure:

Caused by: java.lang.NullPointerException: Inflater has been closed
at kotlin.io.TextStreamsKt.copyTo(ReadWrite.kt:127)
at kotlin.io.TextStreamsKt.copyTo$default(ReadWrite.kt:120)
at kotlin.io.TextStreamsKt.readText(ReadWrite.kt:107)
at com.android.tools.build.jetifier.core.config.ConfigParser.loadDefaultConfig(ConfigParser.kt:54)
at android.databinding.tool.LibTypes$typeRewriter$2.invoke(LibTypes.kt:34)
at android.databinding.tool.LibTypes$typeRewriter$2.invoke(LibTypes.kt:23)
at kotlin.UnsafeLazyImpl.getValue(Lazy.kt:81)
at android.databinding.tool.LibTypes.getTypeRewriter(LibTypes.kt)
at android.databinding.tool.LibTypes.convert(LibTypes.kt:182)
at android.databinding.tool.LibTypes$nonNull$2.invoke(LibTypes.kt:120)
at android.databinding.tool.LibTypes$nonNull$2.invoke(LibTypes.kt:23)
at kotlin.UnsafeLazyImpl.getValue(Lazy.kt:81)
at android.databinding.tool.LibTypes.getNonNull(LibTypes.kt)
at android.databinding.tool.writer.BaseLayoutBinderWriter.<init>(BaseLayoutBinderWriter.kt:52)
at android.databinding.tool.BaseDataBinder.generateAll(BaseDataBinder.kt:54)
at com.android.build.gradle.internal.tasks.databinding.DataBindingGenBaseClassesTask$CodeGenerator.run(DataBindingGenBaseClassesTask.kt:217)
at com.android.build.gradle.internal.tasks.databinding.DataBindingGenBaseClassesTask.writeBaseClasses(DataBindingGenBaseClassesTask.kt:100)

hu...@google.com <hu...@google.com> #29Jul 19, 2019 12:29PM

Thanks for your info.

Finally, I've managed to reproduce this issue and found the root cause. I've explained this in detail at

Issue 137929327

.

I'll write a fix for this.

hu...@google.com <hu...@google.com> #30Aug 21, 2019 04:55PM

We have fixed this issue in Jetifer 1.0.0-beta06:

https://android.googlesource.com/platform/frameworks/support/+/af05c08e2a2f721b3f7411affca883f6a3336513

Can you upgrade your project to use Jetifier 1.0.0-beta06 and let us know if you still have this issue?

hu...@google.com <hu...@google.com> #31Oct 25, 2019 02:17PM

Marked as fixed.

Jetifer 1.0.0-beta06 containing the fix has been integrated into AGP 3.6.0-alpha10.

Issue 120277395

Description

Issue summary

Comments

rm...@google.com <rm...@google.com> #2Dec 5, 2018 06:24AM

ku...@gmail.com <ku...@gmail.com> #3Dec 5, 2018 07:15PM

rm...@google.com <rm...@google.com> Dec 10, 2018 06:48AM

ch...@google.com <ch...@google.com> Jan 7, 2019 07:20PM

zh...@gmail.com <zh...@gmail.com> #4Feb 1, 2019 06:16PM

di...@google.com <di...@google.com> Feb 4, 2019 02:47PM

da...@google.com <da...@google.com> #5Feb 4, 2019 05:07PM

yb...@google.com <yb...@google.com> #6Feb 4, 2019 05:12PM

pa...@google.com <pa...@google.com> #7Feb 4, 2019 07:10PM

yb...@google.com <yb...@google.com> #8Feb 4, 2019 10:18PM

pa...@google.com <pa...@google.com> #9Feb 5, 2019 11:21AM

pa...@google.com <pa...@google.com> #10Feb 5, 2019 11:45AM

hu...@google.com <hu...@google.com> #11Feb 5, 2019 02:35PM

dr...@gmail.com <dr...@gmail.com> #12Feb 5, 2019 05:42PM

hu...@google.com <hu...@google.com> #13Feb 8, 2019 02:19PM

hu...@google.com <hu...@google.com> #14Mar 7, 2019 11:07AM

ku...@gmail.com <ku...@gmail.com> #15Apr 29, 2019 08:11PM

je...@google.com <je...@google.com> #16Apr 29, 2019 09:14PM

hu...@google.com <hu...@google.com> #17Apr 30, 2019 11:39AM

ap...@google.com <ap...@google.com> #18Apr 30, 2019 05:49PM

pa...@google.com <pa...@google.com> #19Apr 30, 2019 05:50PM

hu...@google.com <hu...@google.com> #20May 3, 2019 02:36PM

da...@spotify.com <da...@spotify.com> #21May 10, 2019 06:47PM

me...@gmail.com <me...@gmail.com> #22May 22, 2019 09:09PM

hu...@google.com <hu...@google.com> #23May 24, 2019 04:30PM

hu...@google.com <hu...@google.com> #24Jun 7, 2019 09:06PM

ja...@gmail.com <ja...@gmail.com> #25Jun 11, 2019 11:34PM

hu...@google.com <hu...@google.com> #26Jul 1, 2019 04:58PM

hu...@google.com <hu...@google.com> #27Jul 1, 2019 05:01PM

ku...@gmail.com <ku...@gmail.com> #28Jul 16, 2019 06:15PM

hu...@google.com <hu...@google.com> #29Jul 19, 2019 12:29PM

hu...@google.com <hu...@google.com> #30Aug 21, 2019 04:55PM

hu...@google.com <hu...@google.com> #31Oct 25, 2019 02:17PM

Add comment

Issue metadata