Fixed
Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5499d88b63726e63900b89d3100be1b3a17b84ce
Author: Clara Fok <clarafok@google.com>
Date: Tue Mar 28 17:00:19 2023
Fix set same graph to replace old destinations
When setting the same graph (exact same routes and destinations but different instances), NavController would keep the original graph but replace the existing graph's nodes with the new graph's nodes. Fix the replace logic to ensure this replacement happens. Also replace backqueue's entry destinations with new instances to ensure the graph and backstack is in sync.
Test: ./gradlew navigation:navigation-compose:cC
Bug: 275258161
Bug: 275407804
Relnote: "When NavController sets the same graph with same route and destinations, it now properly replaces its current graph nodes and its bacstack destinations with new instances."
Change-Id: I5bc582e315578ee53383596070ee3ea4a23aed69
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/2512125
Branch: androidx-main
commit 5499d88b63726e63900b89d3100be1b3a17b84ce
Author: Clara Fok <clarafok@google.com>
Date: Tue Mar 28 17:00:19 2023
Fix set same graph to replace old destinations
When setting the same graph (exact same routes and destinations but different instances), NavController would keep the original graph but replace the existing graph's nodes with the new graph's nodes. Fix the replace logic to ensure this replacement happens. Also replace backqueue's entry destinations with new instances to ensure the graph and backstack is in sync.
Test: ./gradlew navigation:navigation-compose:cC
Bug: 275258161
Bug: 275407804
Relnote: "When NavController sets the same graph with same route and destinations, it now properly replaces its current graph nodes and its bacstack destinations with new instances."
Change-Id: I5bc582e315578ee53383596070ee3ea4a23aed69
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
ap...@google.com
Fixed internally and will be available in navigation 2.6.0-alpha09
il...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-compose:2.6.0-alpha09androidx.navigation:navigation-runtime:2.6.0-alpha09
ap...@google.com
Project: platform/prebuilts/androidx/internal
Branch: androidx-master-dev
Author: Ian Lake <
Link:
Add Support Library 28.0.0 prebuilts
Expand for full commit details
Add Support Library 28.0.0 prebuilts
Add the 28.0.0 prebuilts needed by
Navigation.
These were imported using the script at
frameworks/support/development/import_maven_artifacts.py
Test: ./gradlew bOS
BUG: 120293333
Change-Id: I7cbe4ff6000286fab4e1a7d43b20a3d94ad3dd85
Files:
- A
android/arch/lifecycle/common/1.1.1/common-1.1.1.jar - A
android/arch/lifecycle/common/1.1.1/common-1.1.1.jar.md5 - A
android/arch/lifecycle/common/1.1.1/common-1.1.1.jar.sha1 - A
android/arch/lifecycle/common/1.1.1/common-1.1.1.pom - A
android/arch/lifecycle/common/1.1.1/common-1.1.1.pom.md5 - A
android/arch/lifecycle/common/1.1.1/common-1.1.1.pom.sha1 - A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.aar - A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.aar.md5 - A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.aar.sha1 - A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.pom - A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.pom.md5 - A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.pom.sha1 - A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.aar - A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.aar.md5 - A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.aar.sha1 - A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.pom - A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.pom.md5 - A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.pom.sha1 - A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.aar - A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.aar.md5 - A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.aar.sha1 - A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.pom - A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.pom.md5 - A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.pom.sha1 - A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.aar - A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.aar.md5 - A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.aar.sha1 - A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.pom - A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.pom.md5 - A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.pom.sha1 - A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.aar - A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.aar.md5 - A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.aar.sha1 - A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.pom - A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.pom.md5 - A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.pom.sha1 - A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.aar - A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.aar.md5 - A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.aar.sha1 - A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.pom - A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.pom.md5 - A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.pom.sha1 - A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.aar - A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.aar.md5 - A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.aar.sha1 - A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.pom - A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.pom.md5 - A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.pom.sha1 - A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.aar - A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.aar.md5 - A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.aar.sha1 - A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.pom - A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.pom.md5 - A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.pom.sha1 - A
com/android/support/collections/28.0.0/collections-28.0.0.jar - A
com/android/support/collections/28.0.0/collections-28.0.0.jar.md5 - A
com/android/support/collections/28.0.0/collections-28.0.0.jar.sha1 - A
com/android/support/collections/28.0.0/collections-28.0.0.pom - A
com/android/support/collections/28.0.0/collections-28.0.0.pom.md5 - A
com/android/support/collections/28.0.0/collections-28.0.0.pom.sha1 - A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.aar - A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.aar.md5 - A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.aar.sha1 - A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.pom - A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.pom.md5 - A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.pom.sha1 - A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.aar - A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.aar.md5 - A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.aar.sha1 - A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.pom - A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.pom.md5 - A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.pom.sha1 - A
com/android/support/customview/28.0.0/customview-28.0.0.aar - A
com/android/support/customview/28.0.0/customview-28.0.0.aar.md5 - A
com/android/support/customview/28.0.0/customview-28.0.0.aar.sha1 - A
com/android/support/customview/28.0.0/customview-28.0.0.pom - A
com/android/support/customview/28.0.0/customview-28.0.0.pom.md5 - A
com/android/support/customview/28.0.0/customview-28.0.0.pom.sha1 - A
com/android/support/design/28.0.0/design-28.0.0.aar - A
com/android/support/design/28.0.0/design-28.0.0.aar.md5 - A
com/android/support/design/28.0.0/design-28.0.0.aar.sha1 - A
com/android/support/design/28.0.0/design-28.0.0.pom - A
com/android/support/design/28.0.0/design-28.0.0.pom.md5 - A
com/android/support/design/28.0.0/design-28.0.0.pom.sha1 - A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.aar - A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.aar.md5 - A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.aar.sha1 - A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.pom - A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.pom.md5 - A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.pom.sha1 - A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.aar - A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.aar.md5 - A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.aar.sha1 - A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.pom - A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.pom.md5 - A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.pom.sha1 - A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.aar - A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.aar.md5 - A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.aar.sha1 - A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.pom - A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.pom.md5 - A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.pom.sha1 - A
com/android/support/loader/28.0.0/loader-28.0.0.aar - A
com/android/support/loader/28.0.0/loader-28.0.0.aar.md5 - A
com/android/support/loader/28.0.0/loader-28.0.0.aar.sha1 - A
com/android/support/loader/28.0.0/loader-28.0.0.pom - A
com/android/support/loader/28.0.0/loader-28.0.0.pom.md5 - A
com/android/support/loader/28.0.0/loader-28.0.0.pom.sha1 - A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.aar - A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.aar.md5 - A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.aar.sha1 - A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.pom - A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.pom.md5 - A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.pom.sha1 - A
com/android/support/print/28.0.0/print-28.0.0.aar - A
com/android/support/print/28.0.0/print-28.0.0.aar.md5 - A
com/android/support/print/28.0.0/print-28.0.0.aar.sha1 - A
com/android/support/print/28.0.0/print-28.0.0.pom - A
com/android/support/print/28.0.0/print-28.0.0.pom.md5 - A
com/android/support/print/28.0.0/print-28.0.0.pom.sha1 - A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.aar - A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.aar.md5 - A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.aar.sha1 - A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.pom - A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.pom.md5 - A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.pom.sha1 - A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.aar - A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.aar.md5 - A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.aar.sha1 - A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.pom - A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.pom.md5 - A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.pom.sha1 - A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.jar - A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.jar.md5 - A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.jar.sha1 - A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.pom - A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.pom.md5 - A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.pom.sha1 - A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.aar - A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.aar.md5 - A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.aar.sha1 - A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.pom - A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.pom.md5 - A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.pom.sha1 - A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.aar - A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.aar.md5 - A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.aar.sha1 - A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.pom - A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.pom.md5 - A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.pom.sha1 - A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.aar - A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.aar.md5 - A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.aar.sha1 - A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.pom - A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.pom.md5 - A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.pom.sha1 - A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.aar - A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.aar.md5 - A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.aar.sha1 - A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.pom - A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.pom.md5 - A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.pom.sha1 - A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.aar - A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.aar.md5 - A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.aar.sha1 - A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.pom - A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.pom.md5 - A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.pom.sha1 - A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.aar - A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.aar.md5 - A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.aar.sha1 - A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.pom - A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.pom.md5 - A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.pom.sha1 - A
com/android/support/transition/28.0.0/transition-28.0.0.aar - A
com/android/support/transition/28.0.0/transition-28.0.0.aar.md5 - A
com/android/support/transition/28.0.0/transition-28.0.0.aar.sha1 - A
com/android/support/transition/28.0.0/transition-28.0.0.pom - A
com/android/support/transition/28.0.0/transition-28.0.0.pom.md5 - A
com/android/support/transition/28.0.0/transition-28.0.0.pom.sha1 - A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.aar - A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.aar.md5 - A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.aar.sha1 - A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.pom - A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.pom.md5 - A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.pom.sha1 - A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.aar - A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.aar.md5 - A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.aar.sha1 - A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.pom - A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.pom.md5 - A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.pom.sha1
Hash: 94459c8c5f26bae7832a8808bf7e2537df3f0fc3
Date: Fri Nov 30 14:43:41 2018
Description
Version used: 1.0.0-alpha07
Navigation should depend on the latest stable Support Library to ensure a clean transition to a future version that depends on AndroidX.