Fixed
Status Update
Comments
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ap...@google.com <ap...@google.com> #3
il...@google.com <il...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com <ap...@google.com> #5
Project: platform/prebuilts/androidx/internal
Branch: androidx-master-dev
Author: Ian Lake <
Link:
Add Support Library 28.0.0 prebuilts
Expand for full commit details
Add Support Library 28.0.0 prebuilts
Add the 28.0.0 prebuilts needed by
Navigation.
These were imported using the script at
frameworks/support/development/import_maven_artifacts.py
Test: ./gradlew bOS
BUG: 120293333
Change-Id: I7cbe4ff6000286fab4e1a7d43b20a3d94ad3dd85
Files:
- A
android/arch/lifecycle/common/1.1.1/common-1.1.1.jar
- A
android/arch/lifecycle/common/1.1.1/common-1.1.1.jar.md5
- A
android/arch/lifecycle/common/1.1.1/common-1.1.1.jar.sha1
- A
android/arch/lifecycle/common/1.1.1/common-1.1.1.pom
- A
android/arch/lifecycle/common/1.1.1/common-1.1.1.pom.md5
- A
android/arch/lifecycle/common/1.1.1/common-1.1.1.pom.sha1
- A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.aar
- A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.aar.md5
- A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.aar.sha1
- A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.pom
- A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.pom.md5
- A
android/arch/lifecycle/livedata-core/1.1.1/livedata-core-1.1.1.pom.sha1
- A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.aar
- A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.aar.md5
- A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.aar.sha1
- A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.pom
- A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.pom.md5
- A
android/arch/lifecycle/livedata/1.1.1/livedata-1.1.1.pom.sha1
- A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.aar
- A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.aar.md5
- A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.aar.sha1
- A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.pom
- A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.pom.md5
- A
android/arch/lifecycle/runtime/1.1.1/runtime-1.1.1.pom.sha1
- A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.aar
- A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.aar.md5
- A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.aar.sha1
- A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.pom
- A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.pom.md5
- A
android/arch/lifecycle/viewmodel/1.1.1/viewmodel-1.1.1.pom.sha1
- A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.aar
- A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.aar.md5
- A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.aar.sha1
- A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.pom
- A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.pom.md5
- A
com/android/support/animated-vector-drawable/28.0.0/animated-vector-drawable-28.0.0.pom.sha1
- A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.aar
- A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.aar.md5
- A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.aar.sha1
- A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.pom
- A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.pom.md5
- A
com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.pom.sha1
- A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.aar
- A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.aar.md5
- A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.aar.sha1
- A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.pom
- A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.pom.md5
- A
com/android/support/asynclayoutinflater/28.0.0/asynclayoutinflater-28.0.0.pom.sha1
- A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.aar
- A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.aar.md5
- A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.aar.sha1
- A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.pom
- A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.pom.md5
- A
com/android/support/cardview-v7/28.0.0/cardview-v7-28.0.0.pom.sha1
- A
com/android/support/collections/28.0.0/collections-28.0.0.jar
- A
com/android/support/collections/28.0.0/collections-28.0.0.jar.md5
- A
com/android/support/collections/28.0.0/collections-28.0.0.jar.sha1
- A
com/android/support/collections/28.0.0/collections-28.0.0.pom
- A
com/android/support/collections/28.0.0/collections-28.0.0.pom.md5
- A
com/android/support/collections/28.0.0/collections-28.0.0.pom.sha1
- A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.aar
- A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.aar.md5
- A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.aar.sha1
- A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.pom
- A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.pom.md5
- A
com/android/support/coordinatorlayout/28.0.0/coordinatorlayout-28.0.0.pom.sha1
- A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.aar
- A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.aar.md5
- A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.aar.sha1
- A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.pom
- A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.pom.md5
- A
com/android/support/cursoradapter/28.0.0/cursoradapter-28.0.0.pom.sha1
- A
com/android/support/customview/28.0.0/customview-28.0.0.aar
- A
com/android/support/customview/28.0.0/customview-28.0.0.aar.md5
- A
com/android/support/customview/28.0.0/customview-28.0.0.aar.sha1
- A
com/android/support/customview/28.0.0/customview-28.0.0.pom
- A
com/android/support/customview/28.0.0/customview-28.0.0.pom.md5
- A
com/android/support/customview/28.0.0/customview-28.0.0.pom.sha1
- A
com/android/support/design/28.0.0/design-28.0.0.aar
- A
com/android/support/design/28.0.0/design-28.0.0.aar.md5
- A
com/android/support/design/28.0.0/design-28.0.0.aar.sha1
- A
com/android/support/design/28.0.0/design-28.0.0.pom
- A
com/android/support/design/28.0.0/design-28.0.0.pom.md5
- A
com/android/support/design/28.0.0/design-28.0.0.pom.sha1
- A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.aar
- A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.aar.md5
- A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.aar.sha1
- A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.pom
- A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.pom.md5
- A
com/android/support/documentfile/28.0.0/documentfile-28.0.0.pom.sha1
- A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.aar
- A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.aar.md5
- A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.aar.sha1
- A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.pom
- A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.pom.md5
- A
com/android/support/drawerlayout/28.0.0/drawerlayout-28.0.0.pom.sha1
- A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.aar
- A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.aar.md5
- A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.aar.sha1
- A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.pom
- A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.pom.md5
- A
com/android/support/interpolator/28.0.0/interpolator-28.0.0.pom.sha1
- A
com/android/support/loader/28.0.0/loader-28.0.0.aar
- A
com/android/support/loader/28.0.0/loader-28.0.0.aar.md5
- A
com/android/support/loader/28.0.0/loader-28.0.0.aar.sha1
- A
com/android/support/loader/28.0.0/loader-28.0.0.pom
- A
com/android/support/loader/28.0.0/loader-28.0.0.pom.md5
- A
com/android/support/loader/28.0.0/loader-28.0.0.pom.sha1
- A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.aar
- A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.aar.md5
- A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.aar.sha1
- A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.pom
- A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.pom.md5
- A
com/android/support/localbroadcastmanager/28.0.0/localbroadcastmanager-28.0.0.pom.sha1
- A
com/android/support/print/28.0.0/print-28.0.0.aar
- A
com/android/support/print/28.0.0/print-28.0.0.aar.md5
- A
com/android/support/print/28.0.0/print-28.0.0.aar.sha1
- A
com/android/support/print/28.0.0/print-28.0.0.pom
- A
com/android/support/print/28.0.0/print-28.0.0.pom.md5
- A
com/android/support/print/28.0.0/print-28.0.0.pom.sha1
- A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.aar
- A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.aar.md5
- A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.aar.sha1
- A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.pom
- A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.pom.md5
- A
com/android/support/recyclerview-v7/28.0.0/recyclerview-v7-28.0.0.pom.sha1
- A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.aar
- A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.aar.md5
- A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.aar.sha1
- A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.pom
- A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.pom.md5
- A
com/android/support/slidingpanelayout/28.0.0/slidingpanelayout-28.0.0.pom.sha1
- A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.jar
- A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.jar.md5
- A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.jar.sha1
- A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.pom
- A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.pom.md5
- A
com/android/support/support-annotations/28.0.0/support-annotations-28.0.0.pom.sha1
- A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.aar
- A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.aar.md5
- A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.aar.sha1
- A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.pom
- A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.pom.md5
- A
com/android/support/support-compat/28.0.0/support-compat-28.0.0.pom.sha1
- A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.aar
- A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.aar.md5
- A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.aar.sha1
- A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.pom
- A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.pom.md5
- A
com/android/support/support-core-ui/28.0.0/support-core-ui-28.0.0.pom.sha1
- A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.aar
- A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.aar.md5
- A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.aar.sha1
- A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.pom
- A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.pom.md5
- A
com/android/support/support-core-utils/28.0.0/support-core-utils-28.0.0.pom.sha1
- A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.aar
- A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.aar.md5
- A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.aar.sha1
- A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.pom
- A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.pom.md5
- A
com/android/support/support-fragment/28.0.0/support-fragment-28.0.0.pom.sha1
- A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.aar
- A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.aar.md5
- A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.aar.sha1
- A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.pom
- A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.pom.md5
- A
com/android/support/support-vector-drawable/28.0.0/support-vector-drawable-28.0.0.pom.sha1
- A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.aar
- A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.aar.md5
- A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.aar.sha1
- A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.pom
- A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.pom.md5
- A
com/android/support/swiperefreshlayout/28.0.0/swiperefreshlayout-28.0.0.pom.sha1
- A
com/android/support/transition/28.0.0/transition-28.0.0.aar
- A
com/android/support/transition/28.0.0/transition-28.0.0.aar.md5
- A
com/android/support/transition/28.0.0/transition-28.0.0.aar.sha1
- A
com/android/support/transition/28.0.0/transition-28.0.0.pom
- A
com/android/support/transition/28.0.0/transition-28.0.0.pom.md5
- A
com/android/support/transition/28.0.0/transition-28.0.0.pom.sha1
- A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.aar
- A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.aar.md5
- A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.aar.sha1
- A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.pom
- A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.pom.md5
- A
com/android/support/versionedparcelable/28.0.0/versionedparcelable-28.0.0.pom.sha1
- A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.aar
- A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.aar.md5
- A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.aar.sha1
- A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.pom
- A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.pom.md5
- A
com/android/support/viewpager/28.0.0/viewpager-28.0.0.pom.sha1
Hash: 94459c8c5f26bae7832a8808bf7e2537df3f0fc3
Date: Fri Nov 30 14:43:41 2018
Description
Version used: 1.0.0-alpha07
Navigation should depend on the latest stable Support Library to ensure a clean transition to a future version that depends on AndroidX.