Fixed
Status Update
Comments
na...@gmail.com <na...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit f796782ea16c76f151e7d7635945f2f27c1190a0
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 01:26:40 2021
[GH] [FragmentStrictMode] Detect calls to Fragment#setTargetFragment
## Proposed Changes
- Detect calls to `Fragment#setTargetFragment`
## Testing
Test: See `FragmentStrictModeTest#detectSetTargetFragment`
## Issues Fixed
Fixes: 153737745
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/139 .
Resolves #139
Github-Pr-Head-Sha: 89c830c8fe9c487e0dd14087dc99a720496d5c0f
GitOrigin-RevId: e73f51cf62e973d664cdfd8193b830e24e007a7c
Change-Id: I3066e87ed7cfa2bda19089979c722f1efe4103cf
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.java
https://android-review.googlesource.com/1640408
Branch: androidx-main
commit f796782ea16c76f151e7d7635945f2f27c1190a0
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 01:26:40 2021
[GH] [FragmentStrictMode] Detect calls to Fragment#setTargetFragment
## Proposed Changes
- Detect calls to `Fragment#setTargetFragment`
## Testing
Test: See `FragmentStrictModeTest#detectSetTargetFragment`
## Issues Fixed
Fixes: 153737745
This is an imported pull request from
Resolves #139
Github-Pr-Head-Sha: 89c830c8fe9c487e0dd14087dc99a720496d5c0f
GitOrigin-RevId: e73f51cf62e973d664cdfd8193b830e24e007a7c
Change-Id: I3066e87ed7cfa2bda19089979c722f1efe4103cf
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.java
ra...@google.com <ra...@google.com> #3
Can you send us a code sample which reproduces the problem ?
The only obvious this could happen looking at our code, is if your Worker returned a `null` result. I am trying to understand if there is a chance that might happen inside from your Worker.
The only obvious this could happen looking at our code, is if your Worker returned a `null` result. I am trying to understand if there is a chance that might happen inside from your Worker.
su...@google.com <su...@google.com> #4
Handled in https://android-review.googlesource.com/c/platform/frameworks/support/+/839439 ; but please note the actual problem is that your code is returning null for a value that is annotated as @NonNull, so we will mark your work as failed in this situation. You should fix your code.
Description
Version used: 1.0.0-alpha11
Devices/Android versions reproduced on: Android oreo - 8.1
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).