Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
il...@google.com
Converting placeholders into arguments is the documented behavior: https://developer.android.com/reference/androidx/navigation/NavDestination.html#addDeepLink(java.lang.String)
What's missing is that NavDestination doesn't have any API for reading in types or applying that to deep links. We should move that logic from NavInflater to NavDestination so that both XML inflated NavDestinations and programmatically constructed NavDestinations have access to that type information.
What's missing is that NavDestination doesn't have any API for reading in types or applying that to deep links. We should move that logic from NavInflater to NavDestination so that both XML inflated NavDestinations and programmatically constructed NavDestinations have access to that type information.
Description
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on: Nexus 5x Android 6
When setting up with
NavigationUI.setupWithNavController(navigation_drawer, navController)
and
NavigationUI.setupActionBarWithNavController(), the navigation component automatically handles changing the action bar icon into the hamburger drawer or the up arrow when we navigate depending on what page we're on.
However, it does not update the content description for Accessibility correctly when changing the action bar icon. The content description always is "Navigate up" even when the hamburger menu icon is displayed for opening the drawer. (See picture attached)
Alternatively, if we manually set the content description with ActionBarDrawerToggle(this, mDrawerLayout,toolbar,R.string.drawer_open, R.string.drawer_close), then it will always be "open/close drawer".