Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
il...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b17204359581a71c427d7519a6cfc1825141ed72
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Mar 17 21:47:24 2023
Prevent crash when adding unmanaged fragment in nav
Currently, if you attempt to add a fragment to the fragment manager
associated with the FragmentNavigator, navigation crashes as it cannot
find an entry associated with fragment.
While it is strongly recommended to only use navigation APIs to
manipulate the fragment manager, if the back stack is not affected, then
we should not crash.
RelNote: "Adding fragments to the `FragmentNavigator`'s
`FragmentManager` without using navigation will no longer crash."
Test: Added FragmentNavigatorTest
Bug: 274167493
Change-Id: I47d4c75ca46ee7f8282b2a7b97d28d71edd9a07b
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
https://android-review.googlesource.com/2496343
Branch: androidx-main
commit b17204359581a71c427d7519a6cfc1825141ed72
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Mar 17 21:47:24 2023
Prevent crash when adding unmanaged fragment in nav
Currently, if you attempt to add a fragment to the fragment manager
associated with the FragmentNavigator, navigation crashes as it cannot
find an entry associated with fragment.
While it is strongly recommended to only use navigation APIs to
manipulate the fragment manager, if the back stack is not affected, then
we should not crash.
RelNote: "Adding fragments to the `FragmentNavigator`'s
`FragmentManager` without using navigation will no longer crash."
Test: Added FragmentNavigatorTest
Bug: 274167493
Change-Id: I47d4c75ca46ee7f8282b2a7b97d28d71edd9a07b
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
Description
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on: Nexus 5x Android 6
When setting up with
NavigationUI.setupWithNavController(navigation_drawer, navController)
and
NavigationUI.setupActionBarWithNavController(), the navigation component automatically handles changing the action bar icon into the hamburger drawer or the up arrow when we navigate depending on what page we're on.
However, it does not update the content description for Accessibility correctly when changing the action bar icon. The content description always is "Navigate up" even when the hamburger menu icon is displayed for opening the drawer. (See picture attached)
Alternatively, if we manually set the content description with ActionBarDrawerToggle(this, mDrawerLayout,toolbar,R.string.drawer_open, R.string.drawer_close), then it will always be "open/close drawer".