IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 9febd8ad6b63dc1738f11d52333e9ca116735a2e
Author: Jeremy Woods <jbwoods@google.com>
Date:   Thu Jan 20 17:25:17 2022

    Fix improper destination nesting with deep links
   
    When deeplinking to a destination that has multiple nested nav_graphs,
    the handleDeepLink() function will incorrectly remove the start
    destinations of the parent NavGraphs when navigating to child graphs of
    the parent.
   
    What we really want is that you only pop and save destinations when
    navigating to sibling graphs, not child graphs.
   
    RelNote: "Intermediate start destinations will now be present when
    deep linking through multiple nested `NavGraph`s."
    Bug: 214383060
    Test: tested in sample app in bug
    Test: verified no regressions for other handleDeepLink cases
   
    Change-Id: I504c04d2cc4381af22405266192ea0f5094f9c16

M       navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/1956592

Here are my observations with two Navigation versions:

2.3.5
- example.com/user/{userName}/details takes me to exampleFragment, not userProfile (incorrect)
- backbutton: correctly takes me back to the QR scanning app which I opened the URL with (correct)
- up button: takes me to leaderboard (correct)

2.4.0
- example.com/user/{userName}/details takes me to userProfile (correct)
- backbutton: takes me back to exampleFragment (incorrect, it should take me back to the qr scanning app)
- up button: takes me back to exampleFragment (incorrect, it should take me back to the leaderboard)

- Does the fix in 2.4.1 fixes both back and up button (when coming from another app). And when navigating using URI from within the app itself, both back or up button are identical and go back to the previous screen (no intermediate startdestinations from nested graphs) ?
- Any idea how we can already test 2.4.1 ?

Thanks
Wim