Provide a way to handle navigating back and forth between NavHostFragments embedded within other NavHostFragments (or if it's already available, document how to do) [120690961]

Fixed

Feature Request

Status Update

No update yet.

Description

je...@23andme.com

created issue #1

Dec 9, 2018 03:07AM

Component used: Navigation
Version used: 1.0.0-alpha08
Devices/Android versions reproduced on:

Assuming:
- Main Activity has a NavHostFragment, which navigates between Fragment A & Fragment B
- Main activity handles going back with onSupportNavigateUp
- Fragment B has it's own NavHostFragment, which navigated between InnerFragmentB1 & InnerFragmentB2
- Parent NavHostFragment navigates from A -> B (which starts with B1)
- Sub NavHostFragment navigates from B1 -> B2
- Press up: Sub NavHostFragment returns to B1
- Press up: Parent NavHostFragment returns from B to A

What's the proper way of handling these types of situations where we'd like the back button to handle backing out of Inner Fragments first and then Outer Fragments after?

Details here:

https://stackoverflow.com/q/53688934/1229936
Sample Code:

https://github.com/jeffreyfhow/NestedNavFragmentsTest

Comments

so...@gmail.com <so...@gmail.com> #2Dec 9, 2018 07:33AM

FWIW, I've created a PR on https://github.com/androidx/androidx/pull/636 with a regression test.

il...@google.com <il...@google.com> #3Dec 10, 2018 05:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit 812fe658e564bb57b0bea0ae79946d04e2b85610
Author: Simon Marquis <contact@simon-marquis.fr>
Date: Tue Dec 19 21:46:01 2023

[GH] Fix regression in dynamic labels with non-string typed arguments

Regression introduced in

https://github.com/androidx/androidx/commit/76f9009e6cfc1cba5314cad87a6f1923203c54fa Reported in

https://issuetracker.google.com/issues/316676794

Test: ./gradlew navigation:navigation-ui:cC
Fixes: 316676794

[AndroidX Navigation 2.6.0 broke dynamic app bar title for non String arguments](

https://issuetracker.google.com/issues/316676794)

This is an imported pull request from

https://github.com/androidx/androidx/pull/636.

Resolves #636
Github-Pr-Head-Sha: f455c6d1e641cc72cc1bd371b1f47b7d87ec8eff
GitOrigin-RevId: 3ad8f763f17acb22678f1a87e183ef4e7dac5a9d
Change-Id: I94b4e28bb847632663be32b11e481d13789e8c1b

M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-ui/src/androidTest/java/androidx/navigation/ui/NavigationUITest.kt

https://android-review.googlesource.com/2882895

il...@google.com <il...@google.com> Dec 10, 2018 09:55PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #4Dec 14, 2018 12:05AM

Marked as fixed.

Thanks for pointing this out and putting up the PR to fix this! We'll look at doing a Navigation 2.7.7 release with this fix.

ka...@gmail.com <ka...@gmail.com> #5Dec 27, 2018 05:06PM

Awesome, thanks for the quick merge 😀

Issue 120690961