Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
il...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7b17505c2e3679330cf386efe69f1aa95b6ae9e9
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 06 14:47:42 2022
Update safeArgs to AGP 7.0.4
Updating safeArgs to depend on AGP 7.0.4.
Removing the use of reflection from the plugin since we no longer
needed.
RelNote: "Safe Args now depends on Android Gradle Plugin version 7.0.4.
This means that Navigation Safe Args will no longer be compatible with
Android Studio versions prior to 7.0."
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-gradle-plugin:test
Bug: 213086135
Bug: 207670704
Change-Id: I41c88ee06ad827c61cb1bbdc5ba58b3d56155caf
M navigation/navigation-safe-args-gradle-plugin/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/1940534
Branch: androidx-main
commit 7b17505c2e3679330cf386efe69f1aa95b6ae9e9
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 06 14:47:42 2022
Update safeArgs to AGP 7.0.4
Updating safeArgs to depend on AGP 7.0.4.
Removing the use of reflection from the plugin since we no longer
needed.
RelNote: "Safe Args now depends on Android Gradle Plugin version 7.0.4.
This means that Navigation Safe Args will no longer be compatible with
Android Studio versions prior to 7.0."
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-gradle-plugin:test
Bug: 213086135
Bug: 207670704
Change-Id: I41c88ee06ad827c61cb1bbdc5ba58b3d56155caf
M navigation/navigation-safe-args-gradle-plugin/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
[Deleted User] <[Deleted User]>
Do you know if I can try this out in a snapshot or has it been published under a version name? (sorry, things in gerrit still confuse me so maybe its already clear that this is fixed and shipped!)
Description
Version used: 1.0.0-alpha08
Devices/Android versions reproduced on:
I'm trying to use the default navigation animations in my navigation graph. But the default animations (for example nav_default_pop_exit_anim and nav_default_pop_enter_anim) are giving me:
Cannot resolve symbol '@anim/nav_default_pop_enter_anim'. Validates Resource references inside Android XML files.
In my navigation_graph.xml:
<fragment
android:id="@+id/MyFragment"
android:name="com.my.app.mobile.MyFragment"
android:label="MyFragment" >
<action
android:id="@+id/action_MyFragment_to_YourFragment"
app:destination="@+id/YourFragment"
app:enterAnim="@anim/slide_left_enter"
app:exitAnim="@anim/nav_default_pop_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/slide_right_exit"
app:popUpTo="@+id/MyFragment" />
</fragment>
I'm using Android Studio 3.3 RC 2 and my gradle has:
implementation "android.arch.navigation:navigation-fragment-ktx:$navVersion"
implementation "android.arch.navigation:navigation-ui-ktx:$navVersion"
androidTestImplementation "android.arch.navigation:navigation-testing:$navVersion"
where navVersion = "1.0.0-alpha08"
What's weird is that the Navigation Design view has access to these default animations. But when I switch to the Navigation Text view, those same default animations are red with warnings. Has anybody else encountered this problem? How do I get access to these default animations?
I have tried cleaning, rebuilding, syncing Gradle, invalidating and restarting.
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).