Fixed
Status Update
Comments
ab...@gmail.com <ab...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit f570475abb57a6527f861a083ddfccf451b3427b
Author: Sumir Kataria <sumir@google.com>
Date: Wed Aug 29 14:09:32 2018
Add ability to trigger timed work in TestDriver.
Bug: 113360060
Test: Added and ran new tests in TestSchedulerTest.
Change-Id: I681db88e3190b96e90a5d531b7b1fa053eaf8ab9
M work/workmanager-test/src/androidTest/java/androidx/work/test/TestSchedulerTest.java
A work/workmanager-test/src/androidTest/java/androidx/work/test/workers/CountingTestWorker.java
M work/workmanager-test/src/androidTest/java/androidx/work/test/workers/TestWorker.java
M work/workmanager-test/src/main/java/androidx/work/test/TestDriver.java
M work/workmanager-test/src/main/java/androidx/work/test/TestScheduler.java
M work/workmanager-test/src/main/java/androidx/work/test/WorkManagerTestInitHelper.java
https://android-review.googlesource.com/740398
https://goto.google.com/android-sha1/f570475abb57a6527f861a083ddfccf451b3427b
Branch: androidx-master-dev
commit f570475abb57a6527f861a083ddfccf451b3427b
Author: Sumir Kataria <sumir@google.com>
Date: Wed Aug 29 14:09:32 2018
Add ability to trigger timed work in TestDriver.
Bug: 113360060
Test: Added and ran new tests in TestSchedulerTest.
Change-Id: I681db88e3190b96e90a5d531b7b1fa053eaf8ab9
M work/workmanager-test/src/androidTest/java/androidx/work/test/TestSchedulerTest.java
A work/workmanager-test/src/androidTest/java/androidx/work/test/workers/CountingTestWorker.java
M work/workmanager-test/src/androidTest/java/androidx/work/test/workers/TestWorker.java
M work/workmanager-test/src/main/java/androidx/work/test/TestDriver.java
M work/workmanager-test/src/main/java/androidx/work/test/TestScheduler.java
M work/workmanager-test/src/main/java/androidx/work/test/WorkManagerTestInitHelper.java
yb...@google.com <yb...@google.com>
ya...@google.com <ya...@google.com> #3
The testing artifact (work-testing) will have the ability to trigger initial delays and period met signals in alpha09. You should use this to simulate any testing you need.
yb...@google.com <yb...@google.com> #4
Wau, that was incredibly fast, thanks!
ab...@gmail.com <ab...@gmail.com> #5
yes, ready: https://github.com/abbath0767/RoomBugReport
For ChildSecond in generated class SecondDao_Impl (in the case FirstDao_Impl is not a problem) i see next code:
final ContactDetails _tmpContactDetails;
if (! (_cursor.isNull(_cursorIndexOfPhoneNumber) && _cursor.isNull(_cursorIndexOfCountryCode))) {
final String _tmpPhoneNumber;
_tmpPhoneNumber = _cursor.getString(_cursorIndexOfPhoneNumber);
final String _tmpCountryCode;
_tmpCountryCode = _cursor.getString(_cursorIndexOfCountryCode);
_tmpContactDetails = new ContactDetails(_tmpPhoneNumber,_tmpCountryCode);
} else {
_tmpContactDetails = null;
}
_item = new ChildSecond(_tmpEntityId,_tmpSomeField,null);
That is, the problem is exactly the same
For ChildSecond in generated class SecondDao_Impl (in the case FirstDao_Impl is not a problem) i see next code:
final ContactDetails _tmpContactDetails;
if (! (_cursor.isNull(_cursorIndexOfPhoneNumber) && _cursor.isNull(_cursorIndexOfCountryCode))) {
final String _tmpPhoneNumber;
_tmpPhoneNumber = _cursor.getString(_cursorIndexOfPhoneNumber);
final String _tmpCountryCode;
_tmpCountryCode = _cursor.getString(_cursorIndexOfCountryCode);
_tmpContactDetails = new ContactDetails(_tmpPhoneNumber,_tmpCountryCode);
} else {
_tmpContactDetails = null;
}
_item = new ChildSecond(_tmpEntityId,_tmpSomeField,null);
That is, the problem is exactly the same
ab...@gmail.com <ab...@gmail.com> #6
i check it on 2.1.0-alpha03 and issue has reproduce
ya...@google.com <ya...@google.com> #7
Thank you, I can reproduce this now. I'll work on a fix.
da...@google.com <da...@google.com>
ai...@gmail.com <ai...@gmail.com> #8
When child class has empty constructor, field is set to null
[Deleted User] <[Deleted User]> #9
please - Is there any non-AndroidX room library that this bug is known to a) occur in or b) not occur in?
Description
Version used: 1.1.0
Devices/Android versions reproduced on: all
I have two classes:
parent class - parent.kt
child class - child.kt
and standart dao.
But allways return data with null value - contactDetails. In generated code i will see next:
```
//...
final ContactDetails _tmpContactDetails;
if (! (_cursor.isNull(_cursorIndexOfCountryCode) && _cursor.isNull(_cursorIndexOfPhoneNumber))) {
final String _tmpCountryCode;
_tmpCountryCode = _cursor.getString(_cursorIndexOfCountryCode);
final String _tmpPhoneNumber;
_tmpPhoneNumber = _cursor.getString(_cursorIndexOfPhoneNumber);
_tmpContactDetails = new ContactDetails(_tmpCountryCode,_tmpPhoneNumber);
} else {
_tmpContactDetails = null;
}
_item = new ShareAccount(_tmpShareId,_tmpEntityId,_tmpUserId,_tmpOwnerId,null,_tmpCreatedAt,_tmpModifiedAt,_tmpAction);
/....
```
that is, regardless of the value of _tmpContactDetails, it will eventually be set to null.