Room generate error code Dao_Impl.class [121099048]

Fixed

Bug

Status Update

No update yet.

Description

ab...@gmail.com

created issue #1

Dec 17, 2018 02:24PM

Component used: Room
Version used: 1.1.0
Devices/Android versions reproduced on: all

I have two classes:
parent class - parent.kt
child class - child.kt

and standart dao.

But allways return data with null value - contactDetails. In generated code i will see next:
```
//...
final ContactDetails _tmpContactDetails;
if (! (_cursor.isNull(_cursorIndexOfCountryCode) && _cursor.isNull(_cursorIndexOfPhoneNumber))) {
final String _tmpCountryCode;
_tmpCountryCode = _cursor.getString(_cursorIndexOfCountryCode);
final String _tmpPhoneNumber;
_tmpPhoneNumber = _cursor.getString(_cursorIndexOfPhoneNumber);
_tmpContactDetails = new ContactDetails(_tmpCountryCode,_tmpPhoneNumber);
} else {
_tmpContactDetails = null;
}
_item = new ShareAccount(_tmpShareId,_tmpEntityId,_tmpUserId,_tmpOwnerId,null,_tmpCreatedAt,_tmpModifiedAt,_tmpAction);
/....
```
that is, regardless of the value of _tmpContactDetails, it will eventually be set to null.

parent.kt

1.9 KB

Download

child.kt

1.3 KB

Download

Comments

ab...@gmail.com <ab...@gmail.com> #2Dec 17, 2018 02:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

yb...@google.com <yb...@google.com> Dec 17, 2018 05:11PM

Reassigned to da...@google.com.

ya...@google.com <ya...@google.com> #3Jan 8, 2019 05:21AM

Accepted by ya...@google.com.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

yb...@google.com <yb...@google.com> #4Jan 9, 2019 01:39AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ab...@gmail.com <ab...@gmail.com> #5Jan 9, 2019 07:55AM

yes, ready:

https://github.com/abbath0767/RoomBugReport

For ChildSecond in generated class SecondDao_Impl (in the case FirstDao_Impl is not a problem) i see next code:
final ContactDetails _tmpContactDetails;
if (! (_cursor.isNull(_cursorIndexOfPhoneNumber) && _cursor.isNull(_cursorIndexOfCountryCode))) {
final String _tmpPhoneNumber;
_tmpPhoneNumber = _cursor.getString(_cursorIndexOfPhoneNumber);
final String _tmpCountryCode;
_tmpCountryCode = _cursor.getString(_cursorIndexOfCountryCode);
_tmpContactDetails = new ContactDetails(_tmpPhoneNumber,_tmpCountryCode);
} else {
_tmpContactDetails = null;
}
_item = new ChildSecond(_tmpEntityId,_tmpSomeField,null);

That is, the problem is exactly the same

ab...@gmail.com <ab...@gmail.com> #6Jan 9, 2019 11:52AM

i check it on 2.1.0-alpha03 and issue has reproduce

ya...@google.com <ya...@google.com> #7Jan 10, 2019 03:17AM

Thank you, I can reproduce this now. I'll work on a fix.

da...@google.com <da...@google.com> Jan 15, 2019 06:14PM

Marked as fixed.

ai...@gmail.com <ai...@gmail.com> #8Feb 5, 2019 03:38AM

When child class has empty constructor, field is set to null

[Deleted User] <[Deleted User]> #9Jun 26, 2019 10:55PM

please - Is there any non-AndroidX room library that this bug is known to a) occur in or b) not occur in?