Using Navigation 1.0.0-alpha09 Safe Args plugin in a library module fails during Gradle sync [121304903]

Fixed

Bug

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

Dec 20, 2018 03:26PM

Component used: Navigation
Version used: 1.0.0-alpha09
Devices/Android versions reproduced on: Pixel 3 XL (API 28)

Using the Navigation 1.0.0-alpha09 Safe Args plugin fails during Gradle sync with the following exception:

Caused by: kotlin.TypeCastException: null cannot be cast to non-null type org.gradle.api.resources.TextResource
at androidx.navigation.safeargs.gradle.SafeArgsPlugin.setApplicationId(SafeArgsPlugin.kt:87)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin.access$setApplicationId(SafeArgsPlugin.kt:39)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1$task$1.execute(SafeArgsPlugin.kt:63)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1$task$1.execute(SafeArgsPlugin.kt:39)
at org.gradle.api.internal.tasks.DefaultTaskContainer.create(DefaultTaskContainer.java:334)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1.invoke(SafeArgsPlugin.kt:59)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1.invoke(SafeArgsPlugin.kt:39)
at androidx.navigation.safeargs.gradle.SafeArgsPluginKt$sam$org_gradle_api_Action$0.execute(SafeArgsPlugin.kt)

This appears to be a regression introduced by:

https://android-review.googlesource.com/845025

See the attached minimal sample project to reproduce. Downgrading navigation_version to 1.0.0-alpha08 or removing apply plugin: "androidx.navigation.safeargs" from the library module's build.gradle file "fixes" the issue.

NavigationSafeArgsBug.zip

245 KB

Download

Comments

da...@google.com <da...@google.com> Dec 20, 2018 05:05PM

Assigned to da...@google.com.

je...@google.com <je...@google.com> Dec 20, 2018 11:21PM

Reassigned to je...@google.com.

da...@google.com <da...@google.com> #2Jan 9, 2019 06:25PM

Bringing setMaxSchedulerLimit to say 49 doesn't help. Same error.

da...@airbank.net <da...@airbank.net> #3Jan 24, 2019 09:21AM

If you are using work-firebase then you should not be using JobScheduler directly. Can you please send us the full bug report so we can investigate ?

ap...@google.com <ap...@google.com> #4Jan 30, 2019 05:33PM

java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
at android.os.Parcel.readException(Parcel.java:1692)
at android.os.Parcel.readException(Parcel.java:1637)
at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:158)
at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:42)
at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(SystemJobScheduler.java:126)
at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(SystemJobScheduler.java:95)
at androidx.work.impl.Schedulers.scheduleInternal(Schedulers.java:104)
at androidx.work.impl.Schedulers.schedule(Schedulers.java:73)
at androidx.work.impl.WorkerWrapper.setSucceededAndNotify(WorkerWrapper.java:393)
at androidx.work.impl.WorkerWrapper.handleResult(WorkerWrapper.java:255)
at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:181)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:761)

il...@google.com <il...@google.com> #5Jan 30, 2019 05:40PM

Marked as fixed, reassigned to da...@google.com.

What do you mean I shouldn't use JobScheduler directly? Isn't work-firebase is just for <21 devices, otherwise JobScheduler always used?

la...@gmail.com <la...@gmail.com> #6May 24, 2019 02:37PM

I think i was confused by your previous comment. You are right, we only use work-firebase for API < 23.
JobScheduler is used for API >= 23.

This issue should have been resolved in `alpha03` and `alpha04` (we addressed different parts of the problem). If you can reproduce this on a device, then can you do:

1. adb shell dumpsys jobscheduler for your app.
2. Reboot your device.
3. After the reboot, can you re-run adb shell dumpsys jobscheduler ?

I want to check if you see any differences in the jobs created before and after the reboot.

Thanks for your patience.

la...@gmail.com <la...@gmail.com> #7May 24, 2019 02:56PM

Actually for step 2, the easier thing to do is to force stop your app. You don't need to fo a full reboot.