Fixed
Status Update
No update yet.
Comments
da...@google.com
je...@google.com
da...@google.com
Any update on this?
da...@airbank.net
The bug is still present in alpha-11. We can't use safeargs in a library module.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 928c1216993a028b672061d0087431ec20d7bc51
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Jan 28 14:47:04 2019
Safe Args getApplicationIdTextResource workaround.
For some unknown cases the new Android Gradle Plugin method
getApplicationIdTextResource() returns a null TextResource which causes
the Safe Args plugin to fail in projects using versions of the AGP that
are above 3.2. In order to mitigate the issue this CL will still attempt
to use the old method (getApplicationId) if the TextResource returned is
null.
Manual tests have shown that for the cases where the TextResource
is most needed it does not return null (feature modules) and for those
where the old API is good enough (library or app modules) then it is
safe to call getApplicationId() as it won't throw.
Bug: 121304903
Test: Manual tests with AGP 3.3.0 and 3.4.0-beta02 in an app, library
and feature modules. Also updated PluginTest
Change-Id: Ie33d886092744fa2ce638e47f104ae0fd9cab234
M navigation/safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/887873
https://goto.google.com/android-sha1/928c1216993a028b672061d0087431ec20d7bc51
Branch: androidx-master-dev
commit 928c1216993a028b672061d0087431ec20d7bc51
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Jan 28 14:47:04 2019
Safe Args getApplicationIdTextResource workaround.
For some unknown cases the new Android Gradle Plugin method
getApplicationIdTextResource() returns a null TextResource which causes
the Safe Args plugin to fail in projects using versions of the AGP that
are above 3.2. In order to mitigate the issue this CL will still attempt
to use the old method (getApplicationId) if the TextResource returned is
null.
Manual tests have shown that for the cases where the TextResource
is most needed it does not return null (feature modules) and for those
where the old API is good enough (library or app modules) then it is
safe to call getApplicationId() as it won't throw.
Bug: 121304903
Test: Manual tests with AGP 3.3.0 and 3.4.0-beta02 in an app, library
and feature modules. Also updated PluginTest
Change-Id: Ie33d886092744fa2ce638e47f104ae0fd9cab234
M navigation/safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
il...@google.com
We've added a work around so that Navigation continues to work and it'll be available in the next release.
As the underlying issue with the Android Gradle Plugin is not fixed, we've filedhttps://issuetracker.google.com/issues/123635174 which you can star to track progress towards fixing the root cause.
As the underlying issue with the Android Gradle Plugin is not fixed, we've filed
la...@gmail.com
Hi I'm getting this error in navigation 2.0.0 is it supposed to be fixed?
la...@gmail.com
nevermind - was using an outdated gradle plugin
Description
Version used: 1.0.0-alpha09
Devices/Android versions reproduced on: Pixel 3 XL (API 28)
Using the Navigation 1.0.0-alpha09 Safe Args plugin fails during Gradle sync with the following exception:
Caused by: kotlin.TypeCastException: null cannot be cast to non-null type org.gradle.api.resources.TextResource
at androidx.navigation.safeargs.gradle.SafeArgsPlugin.setApplicationId(SafeArgsPlugin.kt:87)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin.access$setApplicationId(SafeArgsPlugin.kt:39)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1$task$1.execute(SafeArgsPlugin.kt:63)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1$task$1.execute(SafeArgsPlugin.kt:39)
at org.gradle.api.internal.tasks.DefaultTaskContainer.create(DefaultTaskContainer.java:334)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1.invoke(SafeArgsPlugin.kt:59)
at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$1.invoke(SafeArgsPlugin.kt:39)
at androidx.navigation.safeargs.gradle.SafeArgsPluginKt$sam$org_gradle_api_Action$0.execute(SafeArgsPlugin.kt)
This appears to be a regression introduced by:
See the attached minimal sample project to reproduce. Downgrading navigation_version to 1.0.0-alpha08 or removing apply plugin: "androidx.navigation.safeargs" from the library module's build.gradle file "fixes" the issue.