IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e36c65f67e49ddbfa0080542295f4a4850ae17da
Author: Sumir Kataria <sumir@google.com>
Date:   Tue Aug 07 13:04:03 2018

    Enforce ConstraintTracker#setState is on the main thread.
   
    - setState now asserts that we are on the main thread
    - Moved assert*Thread methods into their own utils
    - Annotated several tests manually calling onBroadcastReceive
      as @UiThreadTest as our broadcast receivers only operate on
      the main thread (they use the default registerReceiver
      method)
    - NetworkCallbacks are invoked on non-main threads by default;
      in this case, we re-post them to the main thread
   
    This is part of the solution to a concurrency exception in
    ConstraintTracker.
   
    Bug: 112272753
    Test: Updated and ran tests
    Change-Id: I7011e5993b814f4fcafe861e283a827cd1edee12

M       work/workmanager/build.gradle
M       work/workmanager/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M       work/workmanager/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M       work/workmanager/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M       work/workmanager/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M       work/workmanager/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M       work/workmanager/src/main/java/androidx/work/impl/WorkManagerImpl.java
M       work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M       work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/ConstraintTracker.java
M       work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.java
A       work/workmanager/src/main/java/androidx/work/impl/utils/ThreadUtils.java

https://android-review.googlesource.com/727429
https://goto.google.com/android-sha1/e36c65f67e49ddbfa0080542295f4a4850ae17da

Fixed in https://android-review.googlesource.com/c/platform/frameworks/support/+/728180 (not sure why the automated message isn't being shown here).  This should be available in alpha07.

Will this be released in the next beta? Thanks

Yes, it will.

Seems like it's still not fixed:

Fatal Exception: java.util.ConcurrentModificationException
       at java.util.WeakHashMap$HashIterator.next(WeakHashMap.java:165)
       at androidx.work.impl.utils.WakeLocks.checkWakeLocks(WakeLocks.java:78)
       at androidx.work.impl.background.systemalarm.SystemAlarmService.onAllCommandsCompleted(SystemAlarmService.java:69)
       at androidx.work.impl.background.systemalarm.SystemAlarmDispatcher.dequeueAndCheckForCompletion(SystemAlarmDispatcher.java:217)
       at androidx.work.impl.background.systemalarm.SystemAlarmDispatcher$DequeueAndCheckForCompletion.run(SystemAlarmDispatcher.java:317)
       at android.os.Handler.handleCallback(Handler.java:810)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:189)
       at android.app.ActivityThread.main(ActivityThread.java:5532)
       at java.lang.reflect.Method.invoke(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:372)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:950)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:745)

Still happened on beta02, Android 5.0.2

Sample app here: https://issuetracker.google.com/issues/121345393

It's hard to reproduce with SystemAlarmService.onAllCommandsCompleted. Only managed to do it once but it was just luck. The sample app crashes more often though.

I meant this url: https://github.com/rubensousa/WorkManagerConcurrent

Thanks for the bug report and the sample app. Will take another look.

Why are you calling a hidden method (WakeLocks#checkWakeLocks) yourself?

Just to reproduce the crash faster. I don't call this on the production app.

The fix will be available in beta03: https://android-review.googlesource.com/c/platform/frameworks/support/+/876992

Thanks a lot for fixing it quickly ;)

It still seems to happen for me using beta02:

java.util.WeakHashMap$HashIterator.next (WeakHashMap.java:165)
androidx.work.impl.utils.WakeLocks.checkWakeLocks (WakeLocks.java:78)
androidx.work.impl.background.systemalarm.SystemAlarmService.onAllCommandsCompleted (SystemAlarmService.java:69)
androidx.work.impl.background.systemalarm.SystemAlarmDispatcher.dequeueAndCheckForCompletion (SystemAlarmDispatcher.java:217)
androidx.work.impl.background.systemalarm.SystemAlarmDispatcher$DequeueAndCheckForCompletion.run (SystemAlarmDispatcher.java:317)
android.os.Handler.handleCallback (Handler.java:815)
android.os.Handler.dispatchMessage (Handler.java:104)
android.os.Looper.loop (Looper.java:194)
android.app.ActivityThread.main (ActivityThread.java:5624)
java.lang.reflect.Method.invoke (Method.java)
java.lang.reflect.Method.invoke (Method.java:372)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:959)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:754)

Stacktrace is from a X5pro running Android 5.1.

Another fix will be available in beta03.