Crash on screen rotation in ListPreferenceDialogFragmentCompat [122167543]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Jan 1, 2019 02:58AM

Stacktrace:

2018-12-31 18:56:12.569 5471-5471/com.supercilex.robotscouter.debug E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.supercilex.robotscouter.debug, PID: 5471
java.lang.NullPointerException: Attempt to invoke interface method 'androidx.preference.Preference androidx.preference.DialogPreference$TargetFragment.findPreference(java.lang.CharSequence)' on a null object reference
at androidx.preference.PreferenceDialogFragmentCompat.getPreference(PreferenceDialogFragmentCompat.java:177)
at androidx.preference.ListPreferenceDialogFragmentCompat.getListPreference(ListPreferenceDialogFragmentCompat.java:76)
at androidx.preference.ListPreferenceDialogFragmentCompat.onDialogClosed(ListPreferenceDialogFragmentCompat.java:104)
at androidx.preference.PreferenceDialogFragmentCompat.onDismiss(PreferenceDialogFragmentCompat.java:267)
at android.app.Dialog$ListenersHandler.handleMessage(Dialog.java:1393)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6680)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Comments

al...@gmail.com <al...@gmail.com> #2Jan 1, 2019 02:59AM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Android build
Which Android build are you using? (e.g. OPP1.170223.012)

Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)

Android bug report capturing (kindly share complete bugreport)
After reproducing the issue, press the volume up, volume down, and power button simultaneously. This will capture a bug report on your device in the “bug reports” directory.

Alternate method
After reproducing the issue, navigate to “developer settings”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Screen capture of the issue
Press the volume down and power buttons simultaneously. The image will appear in your gallery. Attach the screenshot file to this issue.

Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.

lp...@google.com <lp...@google.com> #3Jan 2, 2019 01:58PM

Status: Duplicate of

120240628

Android build: N/A - firebase crashlytics doesn't provide that information. It happens on both Android 9 and Android 10.
Sample: N/A - it's a race condition can't reproduce it consistently
Frequency: ~1 %
Android bug report capturing: N/A - firebase crashlytics doesn't provide that information

Problem:
In BiometricFragment the mBundle is not always set - so when isDeviceCredentialAllowed is called the mBundle.getBoolean(BiometricPrompt.KEY_ALLOW_DEVICE_CREDENTIAL, false) throws the NullPointerException.

al...@gmail.com <al...@gmail.com> #4Jan 2, 2019 09:16PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0b2dee89f68e9ed41c9552a93fee72364253af41
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Nov 06 10:00:17 2019

Fix possible NPE with BiometricFragment method

The current implementation of
BiometricFragment#setDeviceCredentialAllowed() tries to get a boolean
from mBundle without first checking to see if mBundle is null,
potentially resulting in a NullPointerException. This commit adds in the
null check in order to make calling this method safer. It also adds a
unit test case to exercise this behavior.

Test: ./gradlew biometric:connectedAndroidTest
Fixes: 142599311
Change-Id: I18e03f926ff03c53f8cf1812fbad46ea75db6a32

M biometric/src/androidTest/java/androidx/biometric/BiometricFragmentTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java

https://android-review.googlesource.com/1159943

lp...@google.com <lp...@google.com> Jan 3, 2019 01:55PM

Status: Assigned (reopened)

lp...@google.com <lp...@google.com> #5Jan 3, 2019 03:05PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/5176090922385408/#/history/all)
Created: 2019-11-26 18:05:22.006209+00:00
Changes: aosp/1159943

hp...@gmail.com <hp...@gmail.com> #6Jan 3, 2019 06:49PM

Hi guys. I can also confirm that it still crashes using preferences 1.1.0-alpha02. I ran the barebones sample project included in

https://issuetracker.google.com/issues/120240628 on a Samsung Galaxy J2 Prime running Android 6.0.1.

If I use 1.0.0 version, the NPE issue will not appear. If I use any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02, the NPE issue is there. This issue also exists for MultiSelectListPreference.

hp...@gmail.com <hp...@gmail.com> #7Jan 3, 2019 07:01PM

I also ran it on a Samsung Galaxy J4+ running Android 8.1.0, and it is the same story. There is no NPE issue using preferences 1.0.0, but using any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02 will cause the NPE.

lp...@google.com <lp...@google.com> #8Jan 3, 2019 07:42PM

Thanks for the further details - it appears there are two similar issues here with Fragment - one has been fixed, but there is still one that exists, causing this bug.

Apologies for the inconvenience.

lp...@google.com <lp...@google.com> #9Jan 22, 2019 06:05PM

Marked as fixed.

This has been fixed and will be available in an upcoming release.

lb...@gmail.com <lb...@gmail.com> #10Jan 22, 2019 06:35PM

@9 Which one?

lp...@google.com <lp...@google.com> #11Jan 22, 2019 06:42PM

Both the Fragment issues and a workaround in Preference library to prevent this from happening in the future will be released.

lb...@gmail.com <lb...@gmail.com> #12Jan 22, 2019 06:46PM

@11 I mean in which version exactly should we expect it to happen? What would be in the gradle file?

lp...@google.com <lp...@google.com> #13Jan 22, 2019 06:49PM

alpha03, which is yet to be released.

lb...@gmail.com <lb...@gmail.com> #14Jan 22, 2019 07:13PM

@13 You mean :
implementation 'androidx.fragment:fragment:1.1.0-alpha03' ?

lp...@google.com <lp...@google.com> #15Jan 22, 2019 08:03PM

Oh I see - sorry.

The two fragment fixes will be available in androidx.fragment:fragment:1.1.0-alpha04
However, androidx.preference:preference:1.1.0-alpha03 will depend on fragment alpha04, so you only need to specify androidx.preference:preference:1.1.0-alpha03 to bring in these fixes and other changes in Preference.

lb...@gmail.com <lb...@gmail.com> #16Jan 22, 2019 08:28PM

@15 Thank you

hp...@gmail.com <hp...@gmail.com> #17Jan 25, 2019 03:24AM

nice! will test and provide feedback once the new versions are released. thanks!

hp...@gmail.com <hp...@gmail.com> #18Feb 13, 2019 03:55PM

sorry for the late feedback. I am done testing androidx.preference:preference:1.1.0-alpha03, and the bug is no longer present. I ran the linked sample project above on three devices: Samsung Galaxy J2 Prime running Android 6.0.1, Samsung Galaxy J2 Pro running Android 7.1.1, and a Samsung Galaxy J4+ running Android 8.1.0.

thanks for the fix!

lb...@gmail.com <lb...@gmail.com> #19Feb 13, 2019 05:08PM

@18 I think it might still exist, or something similar:

https://issuetracker.google.com/issues/124274583

lp...@google.com <lp...@google.com> #20Feb 13, 2019 05:28PM

Seems to be unrelated, will track that issue in that bug.

lb...@gmail.com <lb...@gmail.com> #21Feb 13, 2019 08:11PM

@20 I see. Will there be a new version of those soon, to fix similar issues?