Crash on screen rotation in ListPreferenceDialogFragmentCompat [122167543]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Jan 1, 2019 02:58AM

Stacktrace:

2018-12-31 18:56:12.569 5471-5471/com.supercilex.robotscouter.debug E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.supercilex.robotscouter.debug, PID: 5471
java.lang.NullPointerException: Attempt to invoke interface method 'androidx.preference.Preference androidx.preference.DialogPreference$TargetFragment.findPreference(java.lang.CharSequence)' on a null object reference
at androidx.preference.PreferenceDialogFragmentCompat.getPreference(PreferenceDialogFragmentCompat.java:177)
at androidx.preference.ListPreferenceDialogFragmentCompat.getListPreference(ListPreferenceDialogFragmentCompat.java:76)
at androidx.preference.ListPreferenceDialogFragmentCompat.onDialogClosed(ListPreferenceDialogFragmentCompat.java:104)
at androidx.preference.PreferenceDialogFragmentCompat.onDismiss(PreferenceDialogFragmentCompat.java:267)
at android.app.Dialog$ListenersHandler.handleMessage(Dialog.java:1393)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6680)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Comments

al...@gmail.com <al...@gmail.com> #2Jan 1, 2019 02:59AM

Using navigation version 2.6.0 and 2.7.1 the issue still persists.

After further investigation, the behaviour can be corrected by filtering on backstack entries where current state is at least started. In my opinion the name visibleEntries is misleading if it contains entries that are not actually visible or in transition.

lp...@google.com <lp...@google.com> #3Jan 2, 2019 01:58PM

Status: Duplicate of

120240628

Note that as per the visibleEntries documentation, it is expected that there are entries that are in the CREATED state - those are the entries that are in the process of being removed (i.e., they are no longer in the back stack, but have not yet marked their transition as complete).

It is a bug that those entries aren't removed when their exit animation completes and that's what we'll be looking into.

al...@gmail.com <al...@gmail.com> #4Jan 2, 2019 09:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit f61da31809827bfac89af629c88ad9b8423e88b6
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 06 14:14:11 2023

Fix entry not marked complete after view is destroyed

As part of a fix for

b/279644470

in aosp/2566210, when the fragment view is destroyed, we would mark the transitioning (outgoing) entry as complete only if the entry has also been removed from backstack. However, in the simple navigate() case where the outgoing entry is not popped and remains in the backstack, this entry is not marked complete and ends up in the visibleEntries even though the view has been destroyed.

Now the backstack check in ON_DESTROY is no longer necessary to fix the original

b/279644470

bug -- the view being destroyed should be the right signal for completing entries regardless of whether transitioning effects are used. So this check is removed.

Test: ./gradlew navigation:navigation-fragment:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 288520638
Change-Id: I5caa9af1b5bd7084e76d7daf9515f7430bf2489d

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2743918

lp...@google.com <lp...@google.com> Jan 3, 2019 01:55PM

Status: Assigned (reopened)

lp...@google.com <lp...@google.com> #5Jan 3, 2019 03:05PM

Fixed internally and will be available in navigation 2.7.3

hp...@gmail.com <hp...@gmail.com> #6Jan 3, 2019 06:49PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.7.3
androidx.navigation:navigation-runtime:2.7.3

hp...@gmail.com <hp...@gmail.com> #7Jan 3, 2019 07:01PM

The issue no longer persists in version 2.7.3. Thank you all for the update.

lp...@google.com <lp...@google.com> #8Jan 3, 2019 07:42PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.8.0-alpha01
androidx.navigation:navigation-runtime:2.8.0-alpha01

lp...@google.com <lp...@google.com> #9Jan 22, 2019 06:05PM

Marked as fixed.

This has been fixed and will be available in an upcoming release.

lb...@gmail.com <lb...@gmail.com> #10Jan 22, 2019 06:35PM

@9 Which one?

lp...@google.com <lp...@google.com> #11Jan 22, 2019 06:42PM

Both the Fragment issues and a workaround in Preference library to prevent this from happening in the future will be released.

lb...@gmail.com <lb...@gmail.com> #12Jan 22, 2019 06:46PM

@11 I mean in which version exactly should we expect it to happen? What would be in the gradle file?

lp...@google.com <lp...@google.com> #13Jan 22, 2019 06:49PM

alpha03, which is yet to be released.

lb...@gmail.com <lb...@gmail.com> #14Jan 22, 2019 07:13PM

@13 You mean :
implementation 'androidx.fragment:fragment:1.1.0-alpha03' ?

lp...@google.com <lp...@google.com> #15Jan 22, 2019 08:03PM

Oh I see - sorry.

The two fragment fixes will be available in androidx.fragment:fragment:1.1.0-alpha04
However, androidx.preference:preference:1.1.0-alpha03 will depend on fragment alpha04, so you only need to specify androidx.preference:preference:1.1.0-alpha03 to bring in these fixes and other changes in Preference.

lb...@gmail.com <lb...@gmail.com> #16Jan 22, 2019 08:28PM

@15 Thank you

hp...@gmail.com <hp...@gmail.com> #17Jan 25, 2019 03:24AM

nice! will test and provide feedback once the new versions are released. thanks!

hp...@gmail.com <hp...@gmail.com> #18Feb 13, 2019 03:55PM

sorry for the late feedback. I am done testing androidx.preference:preference:1.1.0-alpha03, and the bug is no longer present. I ran the linked sample project above on three devices: Samsung Galaxy J2 Prime running Android 6.0.1, Samsung Galaxy J2 Pro running Android 7.1.1, and a Samsung Galaxy J4+ running Android 8.1.0.

thanks for the fix!

lb...@gmail.com <lb...@gmail.com> #19Feb 13, 2019 05:08PM

@18 I think it might still exist, or something similar:

https://issuetracker.google.com/issues/124274583

lp...@google.com <lp...@google.com> #20Feb 13, 2019 05:28PM

Seems to be unrelated, will track that issue in that bug.

lb...@gmail.com <lb...@gmail.com> #21Feb 13, 2019 08:11PM

@20 I see. Will there be a new version of those soon, to fix similar issues?