Crash on screen rotation in ListPreferenceDialogFragmentCompat [122167543]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Jan 1, 2019 02:58AM

Stacktrace:

2018-12-31 18:56:12.569 5471-5471/com.supercilex.robotscouter.debug E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.supercilex.robotscouter.debug, PID: 5471
java.lang.NullPointerException: Attempt to invoke interface method 'androidx.preference.Preference androidx.preference.DialogPreference$TargetFragment.findPreference(java.lang.CharSequence)' on a null object reference
at androidx.preference.PreferenceDialogFragmentCompat.getPreference(PreferenceDialogFragmentCompat.java:177)
at androidx.preference.ListPreferenceDialogFragmentCompat.getListPreference(ListPreferenceDialogFragmentCompat.java:76)
at androidx.preference.ListPreferenceDialogFragmentCompat.onDialogClosed(ListPreferenceDialogFragmentCompat.java:104)
at androidx.preference.PreferenceDialogFragmentCompat.onDismiss(PreferenceDialogFragmentCompat.java:267)
at android.app.Dialog$ListenersHandler.handleMessage(Dialog.java:1393)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6680)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Comments

al...@gmail.com <al...@gmail.com> #2Jan 1, 2019 02:59AM

lp...@google.com <lp...@google.com> #3Jan 2, 2019 01:58PM

Status: Duplicate of

120240628

lblb636@ Thanks for reporting this bug. I just want to confirm that the issue is the call device button being not responsive according to the uploaded video. It seems like this issue only happened on Windows.

al...@gmail.com <al...@gmail.com> #4Jan 2, 2019 09:16PM

@3 Why does it occur?
And why only from specific API of Android?
On API 28 for example, it doesn't occur...

Please fix this issue for all API versions of the emulator.

lp...@google.com <lp...@google.com> Jan 3, 2019 01:55PM

Status: Assigned (reopened)

lp...@google.com <lp...@google.com> #5Jan 3, 2019 03:05PM

Another similar issue that's related https://b.corp.google.com/issues/226426377

hp...@gmail.com <hp...@gmail.com> #6Jan 3, 2019 06:49PM

RE#4 I need to try this on Windows laptop first and I couldn't repro on MacOS or Linux. But I think this is most likely related to the modem simulator we introduced for API 31. Will need to further investigate.

hp...@gmail.com <hp...@gmail.com> #7Jan 3, 2019 07:01PM

@6 There are plenty of issues on emulator API 31 (and on Android 13 emulator). Many glitches. Spend 5 minutes on it and you will notice.
Why isn't the emulator tested more on Windows OS?
Windows OS is more popular than Linux and MacOS combined (on desktop) ...

lp...@google.com <lp...@google.com> #8Jan 3, 2019 07:42PM

@6 Also please check on all versions of the emulator, to see when this issue started, and fix from there.

lp...@google.com <lp...@google.com> #9Jan 22, 2019 06:05PM

Marked as fixed.

I reproduced this bug on Windows with emulator version 31.2.10-8420304

lb...@gmail.com <lb...@gmail.com> #10Jan 22, 2019 06:35PM

@9 Please test on more API versions.

lp...@google.com <lp...@google.com> #11Jan 22, 2019 06:42PM

Found the root cause when the "call device" button was unresponsive. It became unresponsive because the inbound call failed to initialize. Basically, the modem simulator's shared FD failed. When receive_inbound_call is invoked, it is supposed to make connection to the "host server" via a shared fd but it is flaky on Windows unfortunately.

modem-simulator: receive_inbound_call:101 inbound call from 6505551212
modem-simulator: process_msgs:296 waiting for new messages ...
modem-simulator: main_host_thread:501 got connection at host server at 65094
modem-simulator: start_calling_thread:254 making a connection to main host server 65094
modem-simulator: main_host_thread:507 Detected close from the other side
modem-simulator: start_calling_thread:262 nothing read quit
modem-simulator: main_host_thread:494 looping at main host server at 65094
modem-simulator: start_calling_thread:284 done with this thread

lb...@gmail.com <lb...@gmail.com> #12Jan 22, 2019 06:46PM

@5 I can't reach the link you've provided.

@11 So it could be the same reason that this bug occurs:

https://issuetracker.google.com/issues/233123301
?

lp...@google.com <lp...@google.com> #13Jan 22, 2019 06:49PM

RE#12 I have uploaded a patch to fix this issue. I don't think it's the same reason for https://issuetracker.google.com/issues/233123301

lb...@gmail.com <lb...@gmail.com> #14Jan 22, 2019 07:13PM

@13 OK thanks.
Have you tested it on all API versions, to make sure that it doesn't cause new issues, and also fixes the issue on other places in case it's there too?

lp...@google.com <lp...@google.com> #15Jan 22, 2019 08:03PM

RE#14 This issue is for API 31+, I will check for API 32 and API 33. Thanks for reminding me.

lb...@gmail.com <lb...@gmail.com> #16Jan 22, 2019 08:28PM

@15 Please check before too, to make sure it doesn't cause new issues

hp...@gmail.com <hp...@gmail.com> #17Jan 25, 2019 03:24AM

Please fix it for all Android emulator versions.
When will the fix be available?

hp...@gmail.com <hp...@gmail.com> #18Feb 13, 2019 03:55PM

The fix has been merged in both 31 release and 32 release for since 05/2022.

lb...@gmail.com <lb...@gmail.com> #19Feb 13, 2019 05:08PM

@18 Merged, but is it available for all using the normal updates?
On which version ?

lp...@google.com <lp...@google.com> #20Feb 13, 2019 05:28PM

Seems to be unrelated, will track that issue in that bug.

lb...@gmail.com <lb...@gmail.com> #21Feb 13, 2019 08:11PM

@20 I see. Will there be a new version of those soon, to fix similar issues?