Crash after updating to Fragment Testing library v1.1.0-alpha03 [122273087]

Fixed

Bug

Status Update

No update yet.

Description

or...@gmail.com

created issue #1

Jan 3, 2019 10:38AM

Component used:fragment-testing
Version used:1.1.0-alpha03
Devices/Android versions reproduced on:

as per

https://stackoverflow.com/questions/54012481/crash-after-updating-to-fragment-testing-library-v1-1-0-alpha03?noredirect=1#comment94863696_54012481

After updating to androidx.fragment:fragment-testing v1.0-alpha03 we're now getting following crash at end of test.

```
java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.Collection java.util.concurrent.ConcurrentHashMap.values()' on a null object reference
at androidx.lifecycle.ViewModel.clear(ViewModel.java:125)
at androidx.lifecycle.ViewModelStore.clear(ViewModelStore.java:62)
```

Importantly this is test where we're mocking instance of ViewModel being used and issues seems to be related to associated changes to lifecycle-viewmodel v2.1.0-alpha01 which we now have a transitive dependency to. Specifically crash is occurring in following method because mBagOfTags is null

```
final void clear() {
mCleared = true;
for (Object value: mBagOfTags.values()) {
// see comment for the similar call in setTagIfAbsent
closeWithRuntimeException(value);
}
onCleared();
}
```

repo steps:

clone

https://github.com/joreilly/galway-bus-android
checkout `fragment_test_issue ` branch
run `RouteListFragmentTest`

Comments

se...@google.com <se...@google.com> #2Jan 7, 2019 04:07PM

Another option is to provide a setContent like API specifically for Fragments.

E.g., an extension like:

fun Fragment.content(content: @Composable () -> Unit): ComposeView {
    return ComposeView(requireContext()).apply {
        setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
        setContent(content)
    }
}

which would let you write a Fragment like:

class ExampleFragment : Fragment() {
    override fun onCreateView(
        inflater: LayoutInflater,
        container: ViewGroup?,
        savedInstanceState: Bundle?
    ) = content {
        // Write your @Composable content here
        val viewModel: ExampleViewModel = viewModel()
        // or extract it into a separate, testable method
        ExampleComposable(viewModel)
    }
}

or...@gmail.com <or...@gmail.com> #3Jan 7, 2019 04:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit a066a43da39b518751bcbd5baed63decb657f3bb
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jan 16 22:11:03 2024

Add Fragment Compose module in Androidx

Adding Fragment Compose module using the create_project.py script.

RelNote: n/a
Test: ./gradlew updateApi
Bug: 258046948
Change-Id: Ia35d149c8ab0d78331206accf53e25a717f97291

M docs-tip-of-tree/build.gradle
A fragment/fragment-compose/api/current.txt
A fragment/fragment-compose/api/res-current.txt
A fragment/fragment-compose/api/restricted_current.txt
A fragment/fragment-compose/build.gradle
A fragment/fragment-compose/src/main/java/androidx/fragment/androidx-fragment-fragment-compose-documentation.md
M settings.gradle

https://android-review.googlesource.com/2912225

or...@gmail.com <or...@gmail.com> #4Jan 7, 2019 04:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 561cb75bdf7e971f0ba2dec3cdc3286e1b415ecf
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jan 16 23:53:00 2024

Add Fragment.content extension

Provides an easy integration for providing Compose content inside of a
Fragment that sets the ComposeView and ViewCompositionStrategy.

RelNote: "The new Fragment Compose module provides a Fragment.content
extension function to handle setting a Fragment's view in Compose."
Test: added test
Bug: 258046948

Change-Id: Ia166527918517593e94bcae239ff714df4dc00ad

M fragment/fragment-compose/api/current.txt
M fragment/fragment-compose/api/restricted_current.txt
M fragment/fragment-compose/build.gradle
A fragment/fragment-compose/src/androidTest/AndroidManifest.xml
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/test/TestActivity.kt
A fragment/fragment-compose/src/androidTest/res/layout/activity_main.xml
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/Fragment.kt

https://android-review.googlesource.com/2911416

se...@google.com <se...@google.com> #5Jan 7, 2019 04:53PM

This has been fixed internally and will be available in the Fragment 1.7.0-alpha09 release.

or...@gmail.com <or...@gmail.com> #6Jan 7, 2019 06:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.protolayout:protolayout-material-core:1.1.0-rc01
androidx.wear.tiles:tiles-tooling:1.3.0-rc01
androidx.wear.tiles:tiles-tooling-preview:1.3.0-rc01

il...@google.com <il...@google.com> #7Jan 8, 2019 10:58PM

Marked as fixed.

We've fixed this internally in

https://android-review.googlesource.com/863029 to ensure that mocked ViewModels work as before and this will be available in the next version of ViewModel (and Fragment, etc. that relies on it).

Issue 122273087