Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
This also brings back dialog content size animations issues :( But on all devices this time.
See attached video
Repro:
Dialog(
onDismissRequest = {
if (dialogState.canDismiss.value) {
dialogNavigator.hide()
}
},
properties = properties,
content = {
Surface(
modifier = modifier
.safeContentPadding()
.fillMaxWidth(0.8f)
.animateContentSize(),
shape = shape,
color = backgroundColor,
contentColor = contentColor,
) {
.....A composable that change it's size
}
},
)
il...@google.com <il...@google.com> #3
Can you give a fuller example for the animateContentSize()
problem?
mi...@gmail.com <mi...@gmail.com> #4
It does that for all the cases where the content change.
properties = DialogProperties(usePlatformDefaultWidth = false)
var show by remember { mutableStateOf(false) }
LaunchedEffect(Unit) {
delay(1000)
show = true
}
Column {
Text("X")
if (show) {
Text"Y)
}
}
Edit: This was a well known long time issue when not using usePlatformDefaultWidth = false
so we were forced to workaround with that.
Now even with it it trigger that. (Depending on the phone, it's either super slow, or laggy and jumping).
Description
Android Studio 3.3 RC 3
Build #AI-182.5107.16.33.5183351, built on December 14, 2018
JRE: 1.8.0_152-release-1248-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
Navigation Library version used: 1.0.0-alpha09
Repro steps:
1. Create two activities and two fragments
2. Set home fragments for both activities
3. Set up navigation between these two activities as described in the documentation
3. Configure animations in navigation graph for navigation between two activities to a desired animation/transition
app:enterAnim
app:exitAnim
app:popEnterAnim
4. Test the app
Expected result:
- Override Activities default transition with transition specified in navigation graph for enter, exit and pop animations.
Achieved result:
- Animation for enter and exit successfully changed
- Animation for pop actions is still the default activity animation
Additional notes:
Using function overridePendingTransition() works just fine.