Fixed
Status Update
No update yet.
Comments
ra...@google.com
This is due to a bug in Fragment - using 1.1.0-alpha02 of Preference uses a newer Fragment dependency, and fixes this issue.
ru...@gmail.com
Actually, I just checked and it still crashes using 1.1.0-alpha02.
ru...@gmail.com
Could you maybe upload a simpler project with reproduction steps? Or at least provide reproduction steps for the project you linked - Does it crash when using Preference 1.0.0?
This still seems suspiciously similar tohttps://issuetracker.google.com/issues/120240628 , which can not be reproduced with 1.1.0-alpha02 (following the reproduction steps in the first comment).
This still seems suspiciously similar to
su...@google.com
Hi guys. I can also confirm that it still crashes using preferences 1.1.0-alpha02. I ran the barebones sample project included in https://issuetracker.google.com/issues/120240628 on a Samsung Galaxy J2 Prime running Android 6.0.1.
If I use 1.0.0 version, the NPE issue will not appear. If I use any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02, the NPE issue is there. This issue also exists for MultiSelectListPreference.
If I use 1.0.0 version, the NPE issue will not appear. If I use any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02, the NPE issue is there. This issue also exists for MultiSelectListPreference.
ru...@gmail.com
I also ran it on a Samsung Galaxy J4+ running Android 8.1.0, and it is the same story. There is no NPE issue using preferences 1.0.0, but using any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02 will cause the NPE.
ru...@gmail.com
Thanks for the further details - it appears there are two similar issues here with Fragment - one has been fixed, but there is still one that exists, causing this bug.
Apologies for the inconvenience.
Apologies for the inconvenience.
ra...@google.com
This has been fixed and will be available in an upcoming release.
ru...@gmail.com
@9 Which one?
ra...@google.com
Both the Fragment issues and a workaround in Preference library to prevent this from happening in the future will be released.
ra...@google.com
@11 I mean in which version exactly should we expect it to happen? What would be in the gradle file?
ru...@gmail.com
alpha03, which is yet to be released.
ra...@google.com
@13 You mean :
implementation 'androidx.fragment:fragment:1.1.0-alpha03' ?
implementation 'androidx.fragment:fragment:1.1.0-alpha03' ?
to...@gmail.com
Oh I see - sorry.
The two fragment fixes will be available in androidx.fragment:fragment:1.1.0-alpha04
However, androidx.preference:preference:1.1.0-alpha03 will depend on fragment alpha04, so you only need to specify androidx.preference:preference:1.1.0-alpha03 to bring in these fixes and other changes in Preference.
The two fragment fixes will be available in androidx.fragment:fragment:1.1.0-alpha04
However, androidx.preference:preference:1.1.0-alpha03 will depend on fragment alpha04, so you only need to specify androidx.preference:preference:1.1.0-alpha03 to bring in these fixes and other changes in Preference.
su...@google.com
@15 Thank you
ru...@gmail.com
nice! will test and provide feedback once the new versions are released. thanks!
ra...@google.com
to...@gmail.com
sorry for the late feedback. I am done testing androidx.preference:preference:1.1.0-alpha03, and the bug is no longer present. I ran the linked sample project above on three devices: Samsung Galaxy J2 Prime running Android 6.0.1, Samsung Galaxy J2 Pro running Android 7.1.1, and a Samsung Galaxy J4+ running Android 8.1.0.
thanks for the fix!
thanks for the fix!
ru...@gmail.com
to...@gmail.com
Seems to be unrelated, will track that issue in that bug.
to...@gmail.com
@20 I see. Will there be a new version of those soon, to fix similar issues?
to...@gmail.com
Thanks!!! Is there a time estimate for the next beta ?
ru...@gmail.com
#23: Thank you so much for taking another look and solving the issue :)
su...@google.com
#24: Most likely next week.
Description
Version used: 1.0.0-beta1
Devices/Android versions reproduced on: API 19
This seems to be happening on API 19 only.
To reproduce, just add a Thread.sleep(1000) in any worker before returning Result.SUCCESS. Worker is stopped due to cancellation instead of being treated as being successful. This causes the worker to being retried.
In our case, the behavior is the same. We're using RxJava and blocking observable operators to perform network requests. This issue causes API 19 devices to keep running the same worker using the backoff strategy instead of marking it as success.
Sample project: