Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bade7af890d31f0f4a4b094ff1fd475b24fff95c
Author: jbwoods <jbwoods@google.com>
Date: Mon Feb 25 15:49:05 2019
Fix typo in ActivityNavigator
Both popEnterAnim and popExitAnim were getting the intent extra intended
for popEnterAnim in the applyPopAnimationsToPendingTransition method. Made
popExitAnim get the proper extra.
Test: ran nav test app
BUG: 126237567
Change-Id: Iecdcdd62695f66e1a66eeb5ec84df09c1faaff24
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
https://android-review.googlesource.com/912259
https://goto.google.com/android-sha1/bade7af890d31f0f4a4b094ff1fd475b24fff95c
Branch: androidx-master-dev
commit bade7af890d31f0f4a4b094ff1fd475b24fff95c
Author: jbwoods <jbwoods@google.com>
Date: Mon Feb 25 15:49:05 2019
Fix typo in ActivityNavigator
Both popEnterAnim and popExitAnim were getting the intent extra intended
for popEnterAnim in the applyPopAnimationsToPendingTransition method. Made
popExitAnim get the proper extra.
Test: ran nav test app
BUG: 126237567
Change-Id: Iecdcdd62695f66e1a66eeb5ec84df09c1faaff24
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
il...@google.com
Fixed for Navigation 1.0.0-rc02
il...@google.com
FWIW, the second part of #2, where we switched to a constructor that takes a Bundle, has been reverted in https://android-review.googlesource.com/870691 and we'll continue to use an Args.fromBundle(Bundle) static method in Navigation 1.0.0-alpha10.
Description
Version used: 1.0.0-alpha09
Would be nice to have an easier way to access the Args class since the getArguments() of a Fragment or getIntent().getExtras() of an Activity aren't available at construction time, meaning you need to use a lazy property delgate.
Wrapping that up in a type safe way that works with the generated Args classes would be greatly preferable.