IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 1b9ae441be4de3443b138e789c85722bba29c356
Author: Clara F <clarafok@google.com>
Date:   Mon Mar 14 15:26:56 2022

    [GH] Add room-paging-guava module to Room
   
    Create module for integrating Guava into Room Paging
   
    Test: n/a
    Bug: 203666906
   
    This is an imported pull request from https://github.com/androidx/androidx/pull/337.
   
    Resolves #337
   
    Relnote: "Added a new artifact, room-paging-guava, for ListenableFuturePagingSource in
      room-paging."
   
    Github-Pr-Head-Sha: f62df108d6d5dd765c43b1e75472ddd0a097f9de
    GitOrigin-RevId: 8c86aaa8e3a856614cbdccabe07c0d658efb0407
    Change-Id: Ie14a1beef5d3b7ba07f3acc3fdd1f7bfc6fd1b9e

A       room/room-paging-guava/src/androidTest/AndroidManifest.xml
A       room/room-paging-guava/api/public_plus_experimental_current.txt
M       settings.gradle
M       docs-tip-of-tree/build.gradle
A       room/room-paging-guava/api/restricted_current.txt
A       room/room-paging-guava/api/res-current.txt
A       room/room-paging-guava/src/main/AndroidManifest.xml
A       room/room-paging-guava/api/current.txt
A       room/room-paging-guava/build.gradle

https://android-review.googlesource.com/2025245

Project: platform/frameworks/support
Branch: androidx-main

commit eb60980fbbeb3a9d824e721969a54db902c44857
Author: Clara F <clarafok@google.com>
Date:   Tue Mar 15 19:08:03 2022

    [GH] Add room-paging-rxjava3 module to Room
   
    Test: n/a
    Bug: 203666906
    Relnote: Integrating rxjava3 support in Room Paging
   
    This is an imported pull request from https://github.com/androidx/androidx/pull/339.
   
    Resolves #339
    Github-Pr-Head-Sha: 274be4dcfc6f40861b476638c9671503e28129d4
    GitOrigin-RevId: f081e641921b7dd64f1bba5800b4395074f902e1
   
    Change-Id: I00d8884025aa4263a96dc509ccb8e303b53beeb8

M       settings.gradle
A       room/room-paging-rxjava3/src/androidTest/AndroidManifest.xml
A       room/room-paging-rxjava3/api/restricted_current.txt
M       docs-tip-of-tree/build.gradle
A       room/room-paging-rxjava3/api/current.txt
A       room/room-paging-rxjava3/build.gradle
A       room/room-paging-rxjava3/src/main/AndroidManifest.xml
A       room/room-paging-rxjava3/api/public_plus_experimental_current.txt
A       room/room-paging-rxjava3/api/res-current.txt

https://android-review.googlesource.com/2027363

Project: platform/frameworks/support
Branch: androidx-main

commit 41a1d4f8677c57db934d37bb0cd8db9d3f3aae6c
Author: Clara F <clarafok@google.com>
Date:   Tue Mar 15 19:10:36 2022

    [GH] Add room-paging-rxjava2 module to Room
   
    Test: n/a
    Bug: 203666906
    Relnote: "Added new artifact room-paging-rxjava2 for rxjava2 support in Room Paging"
   
    This is an imported pull request from https://github.com/androidx/androidx/pull/338.
   
    Resolves #338
    Github-Pr-Head-Sha: f8c5c6f04217e43bbc4a78b9715deb920b830fa3
    GitOrigin-RevId: 1dbf1e202286c42fc34c89a808d8c421fa1303af
   
    Change-Id: I88f076392f1917c2fec52d3bd58d91e73b12a53b

A       room/room-paging-rxjava2/api/current.txt
A       room/room-paging-rxjava2/api/restricted_current.txt
M       settings.gradle
A       room/room-paging-rxjava2/api/res-current.txt
M       docs-tip-of-tree/build.gradle
A       room/room-paging-rxjava2/src/main/AndroidManifest.xml
A       room/room-paging-rxjava2/build.gradle
A       room/room-paging-rxjava2/src/androidTest/AndroidManifest.xml
A       room/room-paging-rxjava2/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2027364

Project: platform/frameworks/support
Branch: androidx-main

commit 2f45502b3d448965f0e52067e8b39108708d1faf
Author: clarafok <clarafok@google.com>
Date:   Mon Apr 11 15:50:07 2022

    Implement LimitOffsetListenableFuturePagingSource
   
    An abstract implementation of ListenableFuturePagingSource to be
    implemented by Room. Supports Guava operations through ListenableFuture.
   
    Test: ./gradlew room:room-paging-guava:cC
    Bug: 203666906
   
    Change-Id: I3ec746a072d28e856018d03aeb08931a8d42fa93

A       room/room-paging-guava/src/main/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M       room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
A       room/room-paging-guava/src/androidTest/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSourceTest.kt
M       room/room-paging/build.gradle
M       room/room-paging-guava/build.gradle
M       room/room-paging/src/main/kotlin/androidx/room/paging/util/RoomPagingUtil.kt

https://android-review.googlesource.com/2037356

Project: platform/frameworks/support
Branch: androidx-main

commit 76e8c1ef8e3f90ecb1376ec0d0dc418990b7e515
Author: Clara Fok <clarafok@google.com>
Date:   Thu Apr 28 17:05:24 2022

    Hook up room-paging-guava to room-compiler
   
    Test: ./gradlew :room:room-compiler:test
    Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
    Bug: 203666906
    Change-Id: Iaa2e7b542b4398f2e364c0b68896c046589e9a09

M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M       room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A       room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/ListenableFuturePagingSourceQueryResultBinderProvider.kt
A       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M       room/integration-tests/kotlintestapp/build.gradle
A       room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/MultiTypedPagingSourceQueryResultBinderProvider.kt
M       room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M       room/room-paging-guava/build.gradle
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/ItemStore.kt
M       room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A       room/room-compiler/src/test/data/common/input/LimitOffsetListenableFuturePagingSource.java
M       room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/PagingSourceQueryResultBinderProvider.kt
M       testutils/testutils-common/src/main/java/androidx/testutils/FilteringExecutor.kt
M       room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A       room/room-compiler/src/test/data/common/input/ListenableFuturePagingSource.java

https://android-review.googlesource.com/2067883

Project: platform/frameworks/support
Branch: androidx-main

commit a5a856d88a480cbb1d4364f6b3d64ff450411cfd
Author: clarafok <clarafok@google.com>
Date:   Wed May 11 13:52:19 2022

    Implement room-paging-rxjava3 LimitOffsetRxPagingSource
   
    Test: ./gradlew room:room-paging-rxjava3:cC
    Bug: 203666906
    Change-Id: I0127af74e4ec38c0570f56a5783ec2157f9bb9fc

A       room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
A       room/room-paging-rxjava3/src/androidTest/kotlin/androidx/room/paging/rxjava3/LimitOffsetRxPagingSourceTest.kt
M       room/room-paging-rxjava3/build.gradle

https://android-review.googlesource.com/2094107

Project: platform/frameworks/support
Branch: androidx-main

commit c7b01e966accae484bb1dd081e3fa5f3f38047fc
Author: clarafok <clarafok@google.com>
Date:   Thu May 12 15:28:45 2022

    Hook up rxjava3 LimitOffsetRxPagingSource to room-compiler
   
    Test: ./gradlew room:room-compiler:test
    Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
    Bug: 203666906
    Change-Id: I57099d83a8c845263c5031990de3124971ac2363

M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
A       room/room-compiler/src/test/data/common/input/Rx3PagingSource.java
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M       room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A       room/room-compiler/src/test/data/common/input/LimitOffsetRx3PagingSource.java
M       room/integration-tests/kotlintestapp/build.gradle
M       room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A       room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava3PagingSourceQueryResultBinderProvider.kt
M       room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M       room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt

https://android-review.googlesource.com/2097220

Project: platform/frameworks/support
Branch: androidx-main

commit c4782c289e754747e1a98a28e2700836d78d7578
Author: clarafok <clarafok@google.com>
Date:   Fri May 13 14:12:02 2022

    Implement rxjava2 LimitOffsetRxPagingSource
   
    Test: ./gradlew room:room-paging-rxjava2:cC
    Bug: 203666906
    Change-Id: Iefd883d45b18b032bb3a29d51209fc7de169c1aa

A       room/room-paging-rxjava2/src/androidTest/kotlin/androidx/room/paging/rxjava2/LimitOffsetRxPagingSourceTest.kt
M       room/room-paging-rxjava2/build.gradle
A       room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt

https://android-review.googlesource.com/2098470

Project: platform/frameworks/support
Branch: androidx-main

commit d1ba57918465b84aa9564074df68d3136a4f8fcd
Author: clarafok <clarafok@google.com>
Date:   Fri May 13 16:09:09 2022

    Hook up room-paging-rxjava2 to room-compiler
   
    Test: ./gradlew room:room-compiler:test
    Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
    Fixes: 203666906
    Change-Id: Ic8f07f14491ece38b1296ca71c761511218a65a9

M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M       room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M       room/integration-tests/kotlintestapp/build.gradle
M       room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A       room/room-compiler/src/test/data/common/input/Rx2PagingSource.java
A       room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava2PagingSourceQueryResultBinderProvider.kt
M       room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A       room/room-compiler/src/test/data/common/input/LimitOffsetRx2PagingSource.java
A       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M       room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt

https://android-review.googlesource.com/2098475

@Emmanuel, do you have only sources outside of the project tree or also CMakeLists.txt?

Only the sources; CMakeLists.txt is under "app" in the tree that is seen by Android Studio

Thanks for looking into this btw, much appreciated!

Common factor here seems to be that cpp files are located out of android studio/gradle directory structure.

In our case, we use separate android module/library to build cpp files. That module is not a subdirectory of the root project, but located ../../xxx/yyy location. cpp files that this module builds, are also located in multiple levels down from module root level. eg ../../xx/yy.  

I think there is a bug somewhere where it resolves the paths. I'm quite sure that it would work if I create enough empty dummy directories before android studio directory, so that it would not leak out from there, or a separate empty disk image for project :)

This "scanning files bug" has been there also in 3.3 preview. I reported that here https://issuetracker.google.com/issues/112927150 on August 2018.

@tg
The NDK is in a subfolder of F:\Android
CPP files are in subfolders of the project's src/main/jni folder (F:\Development\AS\USBTester\USBTester\src\main\jni)

I have a zip file with a project I can send to you if you contact me privately.

Thanks Davy, I'm emailing you privately

Same situation and same problem with 3.3: we've got cpp files outside of (C:\programs\projectName\src) our Android Studio project structure (C:\programs\projectName\build\android).  Android Studio indexes the entire drive and runs out of memory while "loading symbols" and crashes.

In the app.iml file, it looks like Android Studio has added C:\ as a sources root.  Manually changing that to C:\programs\projectName and restarting Android Studio causes the first round of indexing to complete quickly and behave normally for a few seconds, after which it overwrites the file almost immediately with the same C:\ sources root again, after which it enters the same indexing loop forever.

Hi Nicholas, do you use cmake or ndk-build for your native code? Can you provide more information on the structure of your project? Specifically how are the cpp files referenced? Thank you!

We use ndk-build.  This is on a Windows 8.1 machine.  Here are the (lightly sanitized) gradle and mk files: https://www.dropbox.com/s/wl826flzufuzldq/androidBuild.zip?dl=0  Importing those from scratch caused the same problem several times in a row.

There are a couple absolute paths in there.  I worried that might have been causing the "C:\" sources root, but even making them relative paths (and importing from scratch again) didn't fix it.

Same here, but on macOS High Sierra, Android Gradle Plugin 3.3.0, Gradle: 4.10.1, NDK 18.1.5063045, using ndk-build.

Scanning files to index was taking hours, so I left it overnight. In the morning I find the Android Studio process had read 185.35 GB from the disk and is now asking for more RAM. It either tries to read my whole disk (which is about 400 GB), or reads the same data over and over again. I'm not going to give this thing more RAM to do more of what it does now.

I never imagined that it can get any worse than Android Studio 3.2, but 3.3 is plain unusable.

I tried to create 5 levels of empty directories before the actual project directory, but it did not help. Still stuck on scanning files.

But, I discovered that creating a disk image (MacOS with Diskutility), copied project there and opened. Now the scanning phase completed. Tested with two projects that got stuck when working under home direcotry. Both worked this way.

Thank you for the repro case Nicholas it was extremely helpful. I have a change in flight for 3.3.1 that should fix it.
I don't have a workaround for you but this happens in the case that ndk-build is used and a target builds sources from NDK's android_app_glue along with sources in project folder. In this case, Android Studio incorrectly finds the common ancestor folder, C:\. There may be other ways to hit the bug but that's what's happening in your case.

Getting this stack trace also. Seems to be related.

java.lang.Throwable: The file '/' is not under content entry root '/Applications/Android Studio.app/Contents/bin'
        at com.intellij.openapi.diagnostic.Logger.error(Logger.java:126)
        at com.intellij.openapi.roots.impl.ContentEntryImpl.assertFolderUnderMe(ContentEntryImpl.java:378)
        at com.intellij.openapi.roots.impl.ContentEntryImpl.assertCanAddFolder(ContentEntryImpl.java:290)
        at com.intellij.openapi.roots.impl.ContentEntryImpl.assertCanAddFolder(ContentEntryImpl.java:285)
        at com.intellij.openapi.roots.impl.ContentEntryImpl.addSourceFolder(ContentEntryImpl.java:209)
        at com.intellij.openapi.roots.impl.ContentEntryImpl.addSourceFolder(ContentEntryImpl.java:216)
        at com.intellij.openapi.roots.impl.ContentEntryImpl.addSourceFolder(ContentEntryImpl.java:202)
        at com.intellij.openapi.roots.impl.ContentEntryImpl.addSourceFolder(ContentEntryImpl.java:195)
        at com.android.tools.ndk.GradleWorkspace.lambda$updateContentRoots$7(GradleWorkspace.java:399)
        at com.intellij.openapi.roots.ModuleRootModificationUtil.updateModel(ModuleRootModificationUtil.java:143)
        at com.android.tools.ndk.GradleWorkspace.updateContentRoots(GradleWorkspace.java:374)
        at com.android.tools.ndk.GradleWorkspace.lambda$null$0(GradleWorkspace.java:302)
        at com.intellij.openapi.roots.impl.ProjectRootManagerImpl.mergeRootsChangesDuring(ProjectRootManagerImpl.java:295)
        at com.android.tools.ndk.GradleWorkspace.lambda$null$2(GradleWorkspace.java:301)
        at com.intellij.openapi.application.impl.ApplicationImpl.runWriteAction(ApplicationImpl.java:1038)
        at com.android.tools.ndk.GradleWorkspace.lambda$updateGradleWorkspace$3(GradleWorkspace.java:297)
        at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:315)
        at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:447)
        at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:431)
        at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:415)
        at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
        at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
        at java.awt.EventQueue.access$500(EventQueue.java:98)
        at java.awt.EventQueue$3.run(EventQueue.java:715)
        at java.awt.EventQueue$3.run(EventQueue.java:709)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
        at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:817)
        at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:758)
        at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:394)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
        at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Seems related to this issue https://issuetracker.google.com/123131649

Somehow the home directory is being added as a source root:

<component name="NewModuleRootManager" LANGUAGE_LEVEL="JDK_1_7">
    <output url="file://$MODULE_DIR$/build/intermediates/javac/debug/compileDebugJavaWithJavac/classes" />
    <output-test url="file://$MODULE_DIR$/build/intermediates/javac/debugUnitTest/compileDebugUnitTestJavaWithJavac/classes" />
    <exclude-output />
    <content url="file://$USER_HOME$">
      <sourceFolder url="file://$USER_HOME$" isTestSource="false" />  <------ Bad
    ....

Which forces the entire contents of the user's home directory to be scanned and indexed. We are using C++ libraries outside of the project's root - namely prebuilt Conan packages located in ~/.conan. Is there any workaround?

A workaround that I have found is that when I see that is indexing "C:\" in the "Project Source Files" pane. I go to the app.iml file and remove the content tag that has the "C:\" and save the file. That does that it stops the indexation of "C:\" and continue with the correct source directories.

But that makes that when the indexation "ends", it gets "stuck" (actually looks like is loading something, but never ends), in order to solve that I go to the Gradle pane and refresh the gradle project. When it is finally done, the indexing also ends and Android Studio allows me to build the project.

This particular issue is confirmed as fixed in 3.3.1. The scanning and indexing is still an order of magnitude slower  than 3.2.1 (as is Android Studio overall), but at least now it completes in minutes vs. hours and doesn't crash or run out of memory anymore as per this ticket.

Thanks for verifying!
Can you provide more context around the scanning and indexing slowness you observed with 3.3.1 compared to 3.2.1?
Is it the same as https://issuetracker.google.com/issues/121340427 or something else?
Thanks!

Although the bug is fixed, I still experiment the same problem in Android Studio 3.2.2 and 3.4.

When opening a project with a large amount of .h files (webrtc library), It takes around 10 mins in the indexing phase (long time but ok). The problem comes in the Building Symbols stage, it eats all the RAM avaiable and ends with a Low memory warning that makes the IDE unusable.
You can see in the attached screenshot where I configured the IDE to use 8Gb of RAM. If you increase the value it doesn't solve anything, it just does not stop consiming RAM until it hits the limit, no matter how high it is.

3.2 works ""ok"" (at least it doesn't freeze, but no code completion, syntax highlighting... )

Is there any workaround that could mitigate the issue?

Hi, can you give us some idea about the scale of the number of .h files in your library?
And if it's open source, where we can try to repro it ourselves, that would be even better.

This bug is still showing in 3.4......

To comment #29

Thanks for answering!

Our project has around 60.000 .h/.hpp files.
Unfortunately our project is not open source, however, our biggest dependency is webrtc which is.

I would say that if you create a project that depends on webrtc, you will see the same problem.

Hi, I tried downloading the WebRTC source code following instructions from https://webrtc.org/native-code/android/. There seems to be no CMakeLists.txt in the project and there are ~2300 headers in it. Do you create custom CMakeLists in order to include WebRTC as a dependency for your project?

Also, do you by any chance use Android Studio to open the generated gradle file in step https://webrtc.org/native-code/android/#using-android-studio?

Hello, I am experiencing the same problem on 3.4. My project has around 2,000 .h, .c, and .cpp files. They are located across many different paths on my hard drive. Is there any progress on this issue? Thank you.

Maybe this issue related to this one https://issuetracker.google.com/issues/131854856 ?

This bug is not fixed on Android Studio 4.1.
Same behaviour. Same setup. OS X, c++

Found SO question that describes this as well on 4.1.
https://stackoverflow.com/questions/64401439/

Yes, I have exactly the same issue happening also again with 4.1. With 4.2 it works again.

Exact same issue. It is paralyzing for all ndk c++ game developers. AS 4.1. Thanks

This is fixed in 4.2 and later