Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d92e6ab2da02250bfbff957f733a4a2aaaf0c82c
Author: Ian Lake <ilake@google.com>
Date: Thu Jul 09 16:04:11 2020
Allow multiple destinations in NavDeepLinkBuilder
Expand the ability of NavDeepLinkBuilder to support
adding multiple destinations. This allows developers
to effectively build a custom synthetic back stack
that goes through multiple destinations in the same
graph or through destinations in separate graphs.
This augments, not replaces, the existing synthetic
back stack logic: the start destinations of any
graphs needed to make the chosen destination visible
*are* still added to the back stack.
To maintain behavior compatibility, setArguments()
continues to apply the arguments set there to all
destinations created by the deep link. However, this
CL would be first step to also supporting arguments
at a destination level.
Test: newly added tests pass
Relnote: "`NavDeepLinkBuilder` now supports adding
multiple distinct destinations to the generated
back stack."
BUG: 147913689
Change-Id: I3ee0d5251ec1047774aa4e826b25a6d8cf4ec28d
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.java
M navigation/navigation-common/src/test/java/androidx/navigation/NavDestinationTest.kt
M navigation/navigation-runtime/api/2.4.0-alpha01.txt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
https://android-review.googlesource.com/1359698
Branch: androidx-master-dev
commit d92e6ab2da02250bfbff957f733a4a2aaaf0c82c
Author: Ian Lake <ilake@google.com>
Date: Thu Jul 09 16:04:11 2020
Allow multiple destinations in NavDeepLinkBuilder
Expand the ability of NavDeepLinkBuilder to support
adding multiple destinations. This allows developers
to effectively build a custom synthetic back stack
that goes through multiple destinations in the same
graph or through destinations in separate graphs.
This augments, not replaces, the existing synthetic
back stack logic: the start destinations of any
graphs needed to make the chosen destination visible
*are* still added to the back stack.
To maintain behavior compatibility, setArguments()
continues to apply the arguments set there to all
destinations created by the deep link. However, this
CL would be first step to also supporting arguments
at a destination level.
Test: newly added tests pass
Relnote: "`NavDeepLinkBuilder` now supports adding
multiple distinct destinations to the generated
back stack."
BUG: 147913689
Change-Id: I3ee0d5251ec1047774aa4e826b25a6d8cf4ec28d
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.java
M navigation/navigation-common/src/test/java/androidx/navigation/NavDestinationTest.kt
M navigation/navigation-runtime/api/2.4.0-alpha01.txt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
Description
Version used: 1.0.0-alpha09
It is confusing to have both the MainFragmentDirections.next() static method and direct access to the new MainFragmentDirections.Next() constructor.
The constructor should be private or otherwise hidden to make it clear exactly what developers should use.