Fixed
Status Update
No update yet.
Comments
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e005db789e4c6b6c75fb8ca03a0c4e326868fb91
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 02 14:20:41 2020
Move nav_default animation out of animation sets
All of the nav_default animations are simple fades and do not need to be
inside of a animation set. Moving them out also ensures that if they are
placed in an additional set (i.e. like the new fragment state manager
does to listen for when the animation finishes) they will not flash.
Bug: 167430145
Test: Tested in sample app
Change-Id: I071e922a52301863ba2461ff05b60bb64566430c
M navigation/navigation-ui/src/main/res/anim/nav_default_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_exit_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_exit_anim.xml
https://android-review.googlesource.com/1418719
Branch: androidx-master-dev
commit e005db789e4c6b6c75fb8ca03a0c4e326868fb91
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 02 14:20:41 2020
Move nav_default animation out of animation sets
All of the nav_default animations are simple fades and do not need to be
inside of a animation set. Moving them out also ensures that if they are
placed in an additional set (i.e. like the new fragment state manager
does to listen for when the animation finishes) they will not flash.
Bug: 167430145
Test: Tested in sample app
Change-Id: I071e922a52301863ba2461ff05b60bb64566430c
M navigation/navigation-ui/src/main/res/anim/nav_default_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_exit_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_exit_anim.xml
Description
Version used: 1.0.0-alpha09
It is confusing to have both the MainFragmentDirections.next() static method and direct access to the new MainFragmentDirections.Next() constructor.
The constructor should be private or otherwise hidden to make it clear exactly what developers should use.