MainNavDirections isn't imported in generated classes [123307342]

Fixed

Bug

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Jan 23, 2019 10:15PM

Component used: Navigation
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: N/A – compilation/build issue

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Steps to reproduce:
- Add a global action to a fragment that's in a different package than the main app package

MainNavNoImport.zip

836 KB

Download

Comments

il...@google.com <il...@google.com> #2Jan 23, 2019 10:21PM

Assigned to da...@google.com.

Periods are technically valid characters in schemes as per

https://tools.ietf.org/html/rfc3986#section-3.1 alongside the currently supported + and - characters, so it probably makes sense to add it as a supported character.

I take it your original request was just to note in the documentation that it wasn't supported?

ap...@google.com <ap...@google.com> #3Jan 24, 2019 12:12AM

I really would like to have it fixed.Because we have scheme with periods. I got used to it, by setting new pattern to the field. So for me it's ok now.

il...@google.com <il...@google.com> Jan 24, 2019 12:21AM

Marked as fixed.

[Deleted User] <[Deleted User]> #4Jan 24, 2019 07:35AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 59b75c42c73e4a6a9979207c702e6841e6665268
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 10 15:54:46 2018

Regex escape NavDeepLinks

Ensure that the only deep link regex like
behavior are {argName} and .* blocks and treat
all other characters as literals.

This fixes issues with URLs with query parameters
(where the ? is a special character) and allows
us to support schemes with '+', -', and '.'
characters as per

https://tools.ietf.org/html/rfc3986#section-3.1

Test: NavDeepLinkTest tests pass
BUG: 110057514
BUG: 112806402
Change-Id: If621eb66ed3ca5e0da780c19b30068dd2824d461

M navigation/common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDeepLink.java

https://android-review.googlesource.com/785556

https://goto.google.com/android-sha1/59b75c42c73e4a6a9979207c702e6841e6665268

[Deleted User] <[Deleted User]> #5Jan 24, 2019 04:18PM

The library now supports all schemes supported by

https://tools.ietf.org/html/rfc3986#section-3.1

The regex being used is ^[a-zA-Z]+[+\w\-.]*:

Over to Studio to ensure that Manifest Merger also supports the updated schema types.

il...@google.com <il...@google.com> #6Jan 24, 2019 05:13PM

Yes, Manifest Merger supports this. Pending CL adds test for this scenario.

[Deleted User] <[Deleted User]> #7Jan 24, 2019 08:05PM

Re #6 will do. I think it has to do with naming arguments with capital first letters but I'll see if I can make a minimal example app to demonstrate, as a new bug.

pe...@gmail.com <pe...@gmail.com> #8Jan 25, 2019 07:57PM

How do i fix this?

co...@gmail.com <co...@gmail.com> #9Aug 6, 2024 09:03AM

If you're working with Jetpack Navigation in Android and the generated classes don't import MainNavDirections, it usually points to an issue with your setup or the https://lillestromflytt.no/lager-lillestrom/ navigation component.If after all these steps the issue persists, consider invalidating caches and restarting Android Studio (File > Invalidate Caches / Restart), as sometimes cached data can cause problems with code generation.

co...@gmail.com <co...@gmail.com> #10Aug 7, 2024 04:32PM

It sounds like you are dealing with a coding issue, possibly in a web development or React project. If MainNavDirections isn't being imported in generated classes, you may need to explicitly import it in your files. If you provide more specific details about your setup and the context https://www.exploria.pk/tours/hunza-tour-packages/ in which MainNavDirections is used, I can offer more targeted assistance.

sa...@gmail.com <sa...@gmail.com> #11Jan 23, 2025 06:52AM

Comment has been deleted.

Message last modified on Jan 23, 2025 05:02PM